Bug 263585 - Incomplete Romanian holidays list in the calendar displayed by clicking the the clock
Summary: Incomplete Romanian holidays list in the calendar displayed by clicking the t...
Status: RESOLVED WORKSFORME
Alias: None
Product: kdepimlibs
Classification: Applications
Component: kholidays (show other bugs)
Version: unspecified
Platform: Ubuntu Linux
: NOR wishlist
Target Milestone: ---
Assignee: John Layt
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-01-18 22:37 UTC by flj
Modified: 2023-01-26 02:45 UTC (History)
5 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description flj 2011-01-18 22:37:54 UTC
Version:           unspecified (using KDE 4.4.5) 
OS:                Linux

Holiday list for Romania contains only the first Easter and the first Christmas days as holidays. However, official holidays are set by labor law in Romania, and are a few more:
- 01 and 02 of January
- the first and the second Easter day
- 01 of May
- the first and the second Whit sun day
- the day of the Dormition of the Mother of God
- 01 of December
- 2 days for each of the three annual religious celebrations, declared as such by legal religious cults, other than Christian cults, for the people belonging to these cults

I did my best to translate as close as I could to the law's letter, which possibly yielded not quite natural expressions in English. The English version is available here: http://www.codulmuncii.ro/en. Title III, Article 134 contains the list of public holidays, but its English version is incomplete.

IMO the calendar should display at least the holidays specified by date by the law.


Reproducible: Always

Steps to Reproduce:
Click on the clock widget. The calendar is shown. Navigate through the months, so that you display each month at least once.


Actual Results:  
The only observable holidays are the first Easter day and the first Christmas day.

Expected Results:  
Ideally all holidays should be marked on their corresponding dates.

I know something of coding, but I know nothing about KDE, and I'm very time-constrained. If it's about entering some info in XML or another comprehensible format in a file I can do that. I don't know exactly how the holidays not specified by date are computed, but I'm willing to do the research and provide the information to someone knowledgeable in KDE who is willing to implement the necessary addition or help me do this.
Comment 1 Martin Koller 2012-07-13 21:43:59 UTC
It would be great if you could fill in the missing information directly in the current holiday defintion file (e.g. attach the new file here).
The format is described here:
https://projects.kde.org/projects/kde/kdepimlibs/repository/revisions/master/changes/kholidays/holidays/file-format.txt

The current romanian file is here:
https://projects.kde.org/projects/kde/kdepimlibs/repository/revisions/master/changes/kholidays/holidays/plan2/holiday_ro_ro
Comment 2 Christophe Marin 2013-04-17 17:20:10 UTC
I'm not sure I understand where the issue is (nor if it's still valid)

The days you mentioned are marked as days off. 
As Martin wrote, please check https://projects.kde.org/projects/kde/kdepimlibs/repository/revisions/master/changes/kholidays/holidays/plan2/holiday_ro_ro and tell us what you're missing