Bug 263503 - Thoughts on KGet and dolphin enhancement
Summary: Thoughts on KGet and dolphin enhancement
Status: CONFIRMED
Alias: None
Product: kget
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: Compiled Sources Linux
: NOR wishlist
Target Milestone: ---
Assignee: David E. Narvaez
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-01-18 04:17 UTC by Aaron Lewis
Modified: 2012-11-15 01:38 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments
Implementation of Dolphin integration (3.03 KB, patch)
2012-11-14 12:05 UTC, David E. Narvaez
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Aaron Lewis 2011-01-18 04:17:43 UTC
Version:           SVN (using Devel) 
OS:                Linux

Hi, when i finished downloading files with KGet , right click on "Open Destination" , dolphin opens and it took me time to search for file ( actually not much , but should be avoid ) , so if dolphin opens with *target file* selected , it would be good.

Reproducible: Always
Comment 1 Christoph Feck 2011-01-18 05:36:47 UTC
When I use "dolphin /path/to/dir" Dolphin correctly starts in that directory.

When I use "dolphin /path/to/file.ext" Dolphin _opens_ the file, and says "Loading folder" without ever stopping or listing any files in the directory.

As comment #0 says, it should load the containing directory, selecting the file, and scroll it into view. If you want to open it, just press enter or click on it.

When Dolphin is fixed, KGet (or KTorrent) could start the file manager with the file's URL.
Comment 2 Frank Reininghaus 2011-01-18 19:28:49 UTC
(In reply to comment #1)
> When I use "dolphin /path/to/file.ext" Dolphin _opens_ the file, and says
> "Loading folder" without ever stopping or listing any files in the directory.

The right way to do it is

dolphin --select /path/to/file.ext

However, this only selects the file, but does not make it the current item. It doesn't scroll to the file either. But these things should be easy to fix.

I think that "dolphin /path/to/file.ext" should not open the dir and select the file in every case - if "open archives as folder" is enabled in the settings, I would expect that the archive contents are displayed in the Dolphin window if I launch it with "dolphin /path/to/archive.tar.gz".
Comment 3 Jeroen van Meeuwen (Kolab Systems) 2012-08-24 16:18:36 UTC
Resetting assignee to default as per bug #305719
Comment 4 Frank Reininghaus 2012-08-30 15:47:10 UTC
Reassigning to KGet. See comment 2 for info how this could be implemented.
Comment 5 Lukas Appelhans 2012-08-30 20:04:48 UTC
Hey!

We don't use Dolphin directly, but simply "new KRun(directory, this, 0, true, false);", so I suppose this has to be fixed in kdelibs.

Lukas
Comment 6 David E. Narvaez 2012-11-13 05:28:47 UTC
I would also like to see this implemented, but I also noticed we just KRun the directory which, incidentally, opens Dolphin because it happens to be the file manager of our choice.

That is obviously good because KGet will honor whatever file manager the user has chosen. Yet, I think we can go a bit further and add an integration option to integrate directly to dolphin, e.g. a checkbox reading "Always open destination folders in Dolphin" and then check for that configuration value when opening a destination and decide whether to use a generic KRun or specifically calling dolphin.

What do you think?
Comment 7 David E. Narvaez 2012-11-13 05:30:33 UTC
Readding the kget list to the CC...
Comment 8 David E. Narvaez 2012-11-14 12:05:47 UTC
Created attachment 75243 [details]
Implementation of Dolphin integration

The attached patch implements my proposal. How does it look?
Comment 9 Aaron Lewis 2012-11-15 01:38:15 UTC
Sorry, that I no longer runs KDE4 ... as long as it looks good to you, it's
good.


On Wed, Nov 14, 2012 at 8:05 PM, David E. Narvaez <
david.narvaez@computer.org> wrote:

> https://bugs.kde.org/show_bug.cgi?id=263503
>
> --- Comment #8 from David E. Narvaez <david.narvaez@computer.org> ---
> Created attachment 75243 [details]
>   --> https://bugs.kde.org/attachment.cgi?id=75243&action=edit
> Implementation of Dolphin integration
>
> The attached patch implements my proposal. How does it look?
>
> --
> You are receiving this mail because:
> You reported the bug.
>