Bug 262780 - Breadcrumb navigation not upgraded after disabling script
Summary: Breadcrumb navigation not upgraded after disabling script
Status: RESOLVED FIXED
Alias: None
Product: amarok
Classification: Unclassified
Component: Internet Services (show other bugs)
Version: 2.4-GIT
Platform: Unlisted Binaries Linux
: NOR normal (vote)
Target Milestone: 2.4.0
Assignee: Amarok Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-01-10 20:20 UTC by Daniel Marth
Modified: 2011-01-11 22:26 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In: 2.4.1


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Marth 2011-01-10 20:20:02 UTC
Version:           2.4-GIT (using KDE 4.5.1) 
OS:                Linux

The options after clicking on the arrow next to "Internet" are wrong after enabling/disabling a script.

Reproducible: Always

Steps to Reproduce:
1. Start Amarok with 2 scripts enabled, e.g. CoolStreams and Librivox.org
2. Click on the arrow next to "Internet", both scripts should be shown.
3. Disable one of the scripts.
4. Click on the arrow again.

Actual Results:  
Still both options are shown, so the disabled script is still there.

Expected Results:  
Only the enabled script should be shown.
Comment 1 Myriam Schweingruber 2011-01-10 22:54:30 UTC
Confirmed with current git. The script disappears from the pane list but the breadcrumb list is not updated.
Comment 2 Sergey Ivanov 2011-01-11 21:49:16 UTC
commit 2793e95544ee213ac37ffebd20d3a110dce12580
branch master
Author: Sergey Ivanov <123kash@gmail.com>
Date:   Tue Jan 11 23:47:43 2011 +0300

    Update breadcrumbs on service insert/remove.
    BUG: 262780

diff --git a/ChangeLog b/ChangeLog
index 007fd2a..2df11a6 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -9,6 +9,8 @@ VERISON 2.4.1
   CHANGES:
 
   BUGFIXES:
+    * Fixed issue when breadcrumbs stayed not updated after service insert/remove.
+      (BR 262780)
     * Fixed issue with TagDialog that make metadata fields stay editable if multiple
       streams opened. (BR 177400)
     * Fixed missing equel-sign ('=') in filter string of bookmarks. (BR 245759)
diff --git a/src/browsers/BrowserCategoryList.cpp b/src/browsers/BrowserCategoryList.cpp
index 3b8dc90..74e33f2 100644
--- a/src/browsers/BrowserCategoryList.cpp
+++ b/src/browsers/BrowserCategoryList.cpp
@@ -124,7 +124,7 @@ BrowserCategoryList::addCategory( BrowserCategory * category )
     {
         m_proxyModel->sort( 0 );
     }
-
+    emit( viewChanged() );
 }
 
 
@@ -216,6 +216,7 @@ BrowserCategoryList::removeCategory( const QString &name )
         m_categoryListModel->removeCategory( category );
     delete category;
     m_categoryListView->reset();
+    emit( viewChanged() );
 }
 
 void BrowserCategoryList::slotSetFilterTimeout()