Bug 262551 - Changing the keyboard shortcut to view hidden files in Dolphin does not affect the file/open dialogs
Summary: Changing the keyboard shortcut to view hidden files in Dolphin does not affec...
Status: RESOLVED FIXED
Alias: None
Product: frameworks-kio
Classification: Frameworks and Libraries
Component: general (show other bugs)
Version: unspecified
Platform: Arch Linux Linux
: NOR wishlist
Target Milestone: ---
Assignee: Nate Graham
URL:
Keywords: junior-jobs, usability
Depends on:
Blocks:
 
Reported: 2011-01-08 18:19 UTC by Matteo Varalta
Modified: 2020-09-07 20:13 UTC (History)
6 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
Here it is CTRL + H (47.02 KB, image/png)
2011-01-08 18:19 UTC, Matteo Varalta
Details
Here it is ALT + . (66.48 KB, image/png)
2011-01-08 18:19 UTC, Matteo Varalta
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Matteo Varalta 2011-01-08 18:19:11 UTC
Created attachment 55741 [details]
Here it is CTRL + H

Version:           unspecified (using KDE 4.5.5) 
OS:                Linux

I've changed the keyboard shortcuts "Show hidden file" in Dolphin (e.g.: CTRL+H), but in the "Open file" window the shortcut remains the previous one(Alt+.). 

Reproducible: Always

Steps to Reproduce:
-Modify shortcut "Show hidden files" in dolphin
-Open an Kde sc program (example kate)
-Click on "Open a file": for showing the hidden file you can't use the dolphin shortcuts
Comment 1 Matteo Varalta 2011-01-08 18:19:44 UTC
Created attachment 55742 [details]
Here it is ALT + .
Comment 2 BugCoder 2014-10-28 16:04:52 UTC
Im ussing kubuntu 12.04 and kde 4.13.2 and i have the same problem. In dolphin i have change the shortcut of  "show hidden files" to "Ctrl+h" but in kfile dialog i still have "Alt+.". the shortcut not change.
Comment 3 Nate Graham 2018-04-09 21:18:41 UTC
This is because they use different backends; technically speaking, Dolphin has nothing whatsoever to do with the file open/save dialogs.

That said, this distinction is probably lost on most users, and it makes sense that when changed in Dolphin, the same shortcut would get used in the open/save dialogs too. Perhaps we can have it read Dolphin's config (if available) before using its own internally-defined shortcut.
Comment 4 David Faure 2020-04-13 10:57:05 UTC
The technical solution to make this a single common shortcut is to add this action to the "Standard Shortcuts" (see the module with that name in systemsettings), and then port the filedialog and dolphin to use that standard shortcut. See kconfig/src/gui/kstandardshortcut.h (and optionally kconfigwidgets/src/kstandardaction.h).
Comment 5 Nate Graham 2020-04-13 18:11:49 UTC
Oh duh, of course. I can work on that.
Comment 7 Nate Graham 2020-04-13 19:57:15 UTC
Git commit 65cc12ab3ec8ca313d0e9d9b6d506e9fa9042bc1 by Nate Graham.
Committed on 13/04/2020 at 19:57.
Pushed by ngraham into branch 'master'.

Add standard shortcut for "Show/Hide Hidden Files"

Summary:
Add a standard shortcut for this action so it can be synchronized between different apps
and the file dialog; see https://bugs.kde.org/show_bug.cgi?id=262551.

The action in Dolphin also has F8 bound to this, but the definition here only accept two
default shortcuts, and F8 seems kind of random.

Test Plan: Apply D28803 to KIO and D28804 to Dolphin and test there

Reviewers: dfaure, #frameworks

Reviewed By: dfaure

Subscribers: kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D28802

M  +6    -0    src/gui/kstandardshortcut.cpp
M  +9    -0    src/gui/kstandardshortcut.h

https://commits.kde.org/kconfig/65cc12ab3ec8ca313d0e9d9b6d506e9fa9042bc1
Comment 8 Nate Graham 2020-04-13 20:04:25 UTC
Git commit d3977bdeacbb59a4ef944d381ea6c91ccb1b2d9e by Nate Graham.
Committed on 13/04/2020 at 20:04.
Pushed by ngraham into branch 'master'.

[KDirOperator] Use new "Show/Hide Hidden Files" standard shortcut

Summary:

Depends on D28802

Test Plan:
- Apply D28802 to KConfig
- Apply patch, compile, launch an app
- Open a file dialog
- Hit Ctrl+H or Alt+. and see that hidden files are shown or hidden as appropriate

Reviewers: dfaure, #frameworks

Reviewed By: dfaure

Subscribers: kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D28803

M  +1    -1    src/filewidgets/kdiroperator.cpp

https://commits.kde.org/kio/d3977bdeacbb59a4ef944d381ea6c91ccb1b2d9e
Comment 9 Patrick Silva 2020-04-25 12:26:38 UTC
Could we have ctrl+h and alt+. to show hidden folders in folder selector too?

right-click on wallpaper, choose "Configure desktop..."
set "Wallpaper type" to "Slideshow" and click on "+ Add folder" button
try to show hidden folders by pressing ctrl+h and alt+.

Such shortcuts have no effect.
Comment 10 Patrick Silva 2020-04-25 12:34:01 UTC
Context menu of folder selector has "Show hidden folders" option but its shortcut is F8.

Operating System: KDE neon Unstable Edition
KDE Plasma Version: 5.18.80
KDE Frameworks Version: 5.70.0
Qt Version: 5.14.1
Comment 11 Nate Graham 2020-04-27 20:36:04 UTC
Absolutely!

https://phabricator.kde.org/D29238
Comment 12 Nate Graham 2020-05-06 20:01:05 UTC
Git commit f9f3f6ca260a41d6f387cc40aa5f1539d95b2e68 by Nate Graham.
Committed on 06/05/2020 at 20:00.
Pushed by ngraham into branch 'master'.

Use Standard "Show/Hide Hidden files" shortcuts in directory chooser dialog

Summary:
New standard shortcuts were added in D28802 and adopting them replaces the fairly random
F8 shortcut here.

Depends on D28802

Test Plan:
Open directory chooser dialog from the {nav Add Folder} button in the plasma slideshow
wallpaper dialog and hit Ctrl+H or Alt+.

Reviewers: #plasma, #frameworks, ndavis

Reviewed By: ndavis

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D29238

M  +1    -1    CMakeLists.txt
M  +2    -1    src/platformtheme/kdirselectdialog.cpp

https://commits.kde.org/plasma-integration/f9f3f6ca260a41d6f387cc40aa5f1539d95b2e68
Comment 13 Ahmad Samir 2020-05-29 10:53:49 UTC
This has been fixed, right?
Comment 14 Nate Graham 2020-05-29 13:09:27 UTC
Yep. Not sure why the bug report didn't get closed.
Comment 15 Andreas Sturmlechner 2020-09-03 14:04:56 UTC
That "fairly random" was rather well established and I'm sure quite a few people will trip over that. At least now I know this is not a bug...