Bug 262175 - The widget to select names is not large enough
Summary: The widget to select names is not large enough
Status: RESOLVED FIXED
Alias: None
Product: digikam
Classification: Applications
Component: Faces-Workflow (show other bugs)
Version: 2.0.0
Platform: Unlisted Binaries Linux
: NOR minor
Target Milestone: ---
Assignee: Digikam Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-01-05 11:41 UTC by Julien Narboux
Modified: 2017-08-15 21:49 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In: 4.2.0
Sentry Crash Report:


Attachments
The widget width is too small (640.27 KB, image/png)
2011-04-19 11:30 UTC, Julien Narboux
Details
Debug statements (991 bytes, patch)
2011-04-24 19:27 UTC, Marcel Wiesweg
Details
tagging widget too small (62.19 KB, image/png)
2011-12-26 10:42 UTC, Andi Clemens
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Julien Narboux 2011-01-05 11:41:55 UTC
Version:           2.0.0
OS:                Linux

The widget to select names is not large enough, if the face is small I can not see the label saying that the tag will be created in People or just a tag.

Maybe Create New Tag "toto" in People should be Create New Name "toto" to save some screen space ?

Julien

Reproducible: Sometimes
Comment 1 Marcel Wiesweg 2011-01-05 15:26:50 UTC
In preview view or icon view?
Width or height is not enough?
Comment 2 Julien Narboux 2011-01-05 15:34:21 UTC
In preview view the width is not enough.

Julien
Comment 3 Marcel Wiesweg 2011-02-05 23:59:32 UTC
Git commit 13c21397e857463a64dea631045ae57cbbbca7dd by Marcel Wiesweg.
Committed on 05/02/11 at 23:50.
Pushed by mwiesweg into branch 'development/2.0'.

Shorten the text from "Create new tag <...>" to "Create <...>", to avoid cutting the tag name

CCBUG: 262175

M  +2    -2    digikam/addtagscompletionbox.cpp     

http://commits.kde.org/digikam/13c21397e857463a64dea631045ae57cbbbca7dd
Comment 4 Julien Narboux 2011-04-19 11:30:20 UTC
Created attachment 59126 [details]
The widget width is too small
Comment 5 Julien Narboux 2011-04-19 11:30:58 UTC
The width using current git trunk is still too small, i can only see the word "Create".

Julien
Comment 6 Marcel Wiesweg 2011-04-24 19:27:05 UTC
Created attachment 59280 [details]
Debug statements

There is code to calculate the needed width from the contents in the combobox. For me, the box usually exceeds the width of the line edit. In your screenshot it ends at about 50%.

The attached patch could give some information about what may be wrong. The output is produced when you type a letter in the line edit and autocompletion begins.
Comment 7 caulier.gilles 2011-07-03 15:47:36 UTC
Julien,

Do you take a look about marcel patch to progress in investiguations ?

Gilles Caulier
Comment 8 caulier.gilles 2011-12-14 13:57:59 UTC
Julien

Do you see my comment #7 ?

Gilles Caulier
Comment 9 Andi Clemens 2011-12-26 10:35:56 UTC
This bug is still valid, the widget is too small, the problem for me is the height of the line edit field,I need magnifying glasses to see it :-)

I know the widget is painted over the delegate, so this might not work, but couldn't this widget be wider than the thumbanil?

The problem is that if you define an even smaller thumbnail size, it is not visible at all.
Comment 10 Andi Clemens 2011-12-26 10:42:54 UTC
Created attachment 67122 [details]
tagging widget too small
Comment 11 Marcel Wiesweg 2011-12-26 21:53:44 UTC
See how the height is kept properly even at minimal thumbnail size on my system:
http://wstaw.org/m/2011/12/26/plasma-desktopWp1762.jpg

Why does it work here and not for you?
Comment 12 caulier.gilles 2011-12-26 21:56:37 UTC
Marcel,

This depend of widget style used with digiKam. Under MACOSX, It's a nightmare with Qt mac widget style.

Go to Setup/Misc/Widget Style, and try with another one...

Gilles Caulier
Comment 13 Marcel Wiesweg 2011-12-26 21:59:49 UTC
Ok, I got it: I have switched on to display quite a few items below the picture. If I switch off everything, no widget is visible at all...
Apparently, the placement and size adjustment of the overlay can be improved. This also applies to the grouping icon which you mentioned in another bug report. This opens a whole lot of problems to consider.
Comment 14 caulier.gilles 2014-07-15 07:53:27 UTC
Git commit 0e6d4d7f0fb5303ccbcacd49f3b058d5bd424d52 by Gilles Caulier.
Committed on 15/07/2014 at 07:46.
Pushed by cgilles into branch 'master'.

Do not use a Qwidget as container of AssignNameWidget. This break layout with non Oxgen widget style (fully reproducible under OSX)
Set argin a spacing to 1 pixel into AssignNameWidget layout.
constify and polish implementations
FIXED-IN: 4.2.0

M  +41   -39   digikam/items/assignnameoverlay.cpp
M  +16   -15   digikam/items/assignnameoverlay.h
M  +3    -1    utilities/facemanagement/assignnamewidget.cpp

http://commits.kde.org/digikam/0e6d4d7f0fb5303ccbcacd49f3b058d5bd424d52