Bug 262095 - Can no longer edit multiple transactions in one go
Summary: Can no longer edit multiple transactions in one go
Status: RESOLVED FIXED
Alias: None
Product: kmymoney
Classification: Applications
Component: general (show other bugs)
Version: 4.5.1
Platform: Ubuntu Linux
: NOR normal
Target Milestone: ---
Assignee: KMyMoney Devel Mailing List
URL:
Keywords:
: 250442 (view as bug list)
Depends on:
Blocks:
 
Reported: 2011-01-04 17:56 UTC by Jonathan Clark
Modified: 2011-05-21 22:20 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Clark 2011-01-04 17:56:53 UTC
Version:           4.5.1 (using KDE 4.5.1) 
OS:                Linux

Previous versions of kmymoney allowed me to:
1) select several transactions by ctrl clicking in the ledger or select first then shift select last
2) click 'Edit'
3) Make a change - for example change a date - and click Enter
All selected transactions would have their date changed.

What happens now is that, if I select two transactions, edit, make change, click Enter then the first transaction accepts all the changes, the second transaction is not changed at all. This actually overwrites the changed transaction with data from the other transaction.

This is very serious in the Reconcile view. I used to be able to select multiple transactions (ctrl click again, or select first, Ctrl select last) then right mouse click, mark transaction as reconciled. A whole list would get reconciled. Now I have to right click each transaction individually and mark it reconciled.

This is a major step backwards. It makes using kmymoney much less efficient.

Reproducible: Always

Steps to Reproduce:
Select multiple transactions. Right click, chose edit.

Actual Results:  
A blank transaction form appears and you can change nothing, or the form is pre-filled with one set of details, and you cannot e.g. just change the date.

Expected Results:  
A form appears with just the common data filled in, you can change the common data and the change is applied to all selected transactions.

OS: Linux (x86_64) release 2.6.35-24-generic
Compiler: cc
Comment 1 Thomas Baumgart 2011-01-04 22:01:36 UTC
I think I have fixed that in r1141735 (svn diff -r 1141734:1141735) to fix #242562 in SVN HEAD. Apparently, this fix was never backported. Any volunteers?
Comment 2 Jack 2011-01-04 23:36:54 UTC
Jonathan, Are you aware that you can select multiple transactions in the register (whether in reconcile or normal mode) right click and select to mark the transactions as cleared or reconciled?  Unless this is a new bug, this works correctly, without "editing" the transactions.
Comment 3 Jonathan Clark 2011-01-05 09:25:09 UTC
(In reply to comment #2)
Thank you, I have just re-checked and you are correct. It's not perfect, but good enough. For the record what now happens is I select multiple items (in normal view), right click and choose 'Mark transaction as ...'. That works, the transactions are still selected, but if I now try to right mouse click (to undo what I just did by way of testing) I get the menu but all options except New are greyed out. So I have to unselect and reselect in order to be able to perform a second right mouse click, mark transaction as.... etc. to make a further change.
Comment 4 Cristian Oneț 2011-05-14 11:09:48 UTC
SVN commit 1231876 by conet:

BUG: 262095
When loading the ledger initially we notify everyone that no transaction is selected. After finishing make sure we let them know again what transaction are selected. In short keep KMyMoneyApp's (the one handling the actions) selected transactions list in sync with the transactions selected in the ledger.

 M  +2 -0      kgloballedgerview.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1231876
Comment 5 Cristian Oneț 2011-05-14 11:11:36 UTC
(In reply to comment #3)
> (In reply to comment #2)
> Thank you, I have just re-checked and you are correct. It's not perfect, but
> good enough. For the record what now happens is I select multiple items (in
> normal view), right click and choose 'Mark transaction as ...'. That works, the
> transactions are still selected, but if I now try to right mouse click (to undo
> what I just did by way of testing) I get the menu but all options except New
> are greyed out. So I have to unselect and reselect in order to be able to
> perform a second right mouse click, mark transaction as.... etc. to make a
> further change.

Thanks for the clear description of what was not working correctly. I may have never noticed such an odd behavior :).
Comment 6 Cristian Oneț 2011-05-21 22:11:41 UTC
*** Bug 273205 has been marked as a duplicate of this bug. ***
Comment 7 Cristian Oneț 2011-05-21 22:20:22 UTC
*** Bug 250442 has been marked as a duplicate of this bug. ***