Bug 260357 - JJ: indentation aligns cursor with quotation mark in comment
Summary: JJ: indentation aligns cursor with quotation mark in comment
Status: RESOLVED FIXED
Alias: None
Product: kate
Classification: Applications
Component: indentation (show other bugs)
Version: unspecified
Platform: Gentoo Packages Linux
: NOR normal (vote)
Target Milestone: ---
Assignee: KWrite Developers
URL:
Keywords: junior-jobs
Depends on:
Blocks:
 
Reported: 2010-12-17 11:11 UTC by mjan96
Modified: 2010-12-28 13:54 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description mjan96 2010-12-17 11:11:04 UTC
Version:           unspecified (using KDE 4.5.4) 
OS:                Linux



Reproducible: Always

Steps to Reproduce:
In C++ mode, type the following 1 line
a(); // "b"
and hit Enter.

Actual Results:  
The cursor get aligned with the first quotation mark (column 9 in this example)

Expected Results:  
The cursor should be at the start of the second line.

this bug gets quite annoying if the comment is too long, so it spans multiple displayed lines (while being on one logical line) - when editing the following line, no indentation (Tab, Backspace, Space) is possible. (More precisely, it seems that indentation keys do work, but the apparent effect is none. But holding backspace for long enough solves it).
my Kate version is 3.5.4, as reported in its About dialog 
possibly related to #248973
Comment 1 Milian Wolff 2010-12-17 12:46:27 UTC
should be fixable by checking for "am I in comment" before doing the wrapped-string alignment. 

anyone who knows javascript should be able to fix this, otherwise I'll try to get around to that eventually.
Comment 2 Miquel Sabaté 2010-12-17 13:11:36 UTC
I think I've fixed this bug with my last commit:
https://projects.kde.org/projects/svn-bridge/kate/repository/revisions/81d717c31ea0585dc0915edc0db529e26e35cefe

Can anyone please comfirm it ?
Comment 3 Dominik Haumann 2010-12-17 13:52:44 UTC
Add a unit test and run the cstyle indentation test suite. If there are no regressions, it'll be fine.
Comment 4 Miquel Sabaté 2010-12-17 19:07:19 UTC
Done, no regressions. This bug can now be marked as fixed :)
Comment 5 Milian Wolff 2010-12-17 19:27:31 UTC
thanks
Comment 6 Christoph Cullmann 2010-12-28 13:54:52 UTC
SVN commit 1209880 by cullmann:

Miquel Sabaté <mikisabate@gmail.com>:
  Fixing Bug #260357: JJ: indentation aligns cursor with quotation mark in comment

CCBUG: 260357



 M  +8 -1      cstyle.js  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1209880