Version: SVN trunk (using KDE 4.5.4) OS: Linux in the case of the widgets we design using Qt Designer it would be better to have instead of: contents of kmmwidget.h: #include "ui_kmmwidgetdecl.h" class kmmwidget : public QWidget, public Ui::kmmwidgetdecl { .... }; like it is now, this version: contents of kmmwidget.h: class Ui::kmmwidgetdecl; // forward decl or even pimpl class kmmwidget : public { .... Ui::kmmwidgetdecl *ui; }; contents of kmmwidget.cpp: #include "ui_kmmwidgetdecl.h" This way we could avoid errors caused by included headers which are not yet generated because they are included in another module then the one they are generated in for ex. reports include headers from widgets and building reports starts when widgets is not yet generated. I find this solution much better then explicitly adding cmake dependencies. Since it reduces build time and it's a good practice to avoid polluting header files. Especially the headers of very important classes. Reproducible: Always
SVN commit 1212306 by conet: BUG: 260278 Change all designer based widgets to used the generated code trough composition instead of inheritance. There are more changes to come for this one but I wanted to commit this to get rid of these changes is my sandbox. M +22 -13 kchooseimportexportdlg.cpp M +17 -12 kchooseimportexportdlg.h M +25 -12 kconfirmmanualenterdlg.cpp M +12 -16 kconfirmmanualenterdlg.h M +58 -35 kgncpricesourcedlg.cpp M +5 -18 kgncpricesourcedlg.h M +45 -30 knewfiledlg.cpp M +9 -14 knewfiledlg.h WebSVN link: http://websvn.kde.org/?view=rev&revision=1212306
... because there is more to come :)
SVN commit 1212522 by conet: BUG: 260278 Change all designer based widgets to used the generated code trough composition instead of inheritance. There are more changes to come for this one but I wanted to commit this to get rid of these changes is my sandbox. M +225 -204 dialogs/kfindtransactiondlg.cpp M +15 -17 dialogs/kfindtransactiondlg.h M +34 -12 dialogs/knewbudgetdlg.cpp M +9 -26 dialogs/knewbudgetdlg.h M +86 -85 dialogs/kreportconfigurationfilterdlg.cpp M +2 -0 views/kgloballedgerview.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=1212522
Considering the age of this bug, is it still relevant, or has it been fixed by migrating to Frameworks?
I think we can close this one.
This is not relevant anymore as things have changed too much. I follow Jack's suggestion to close the bug as unmaintained.