Bug 259802 - KOrganizer doesn't list/load holiday region files correctly when more than 1 language is available per country
Summary: KOrganizer doesn't list/load holiday region files correctly when more than 1 ...
Status: RESOLVED FIXED
Alias: None
Product: korganizer
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: Fedora RPMs Linux
: NOR normal
Target Milestone: ---
Assignee: kdepim bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-12-14 05:16 UTC by Dan Ciarniello
Modified: 2015-04-28 16:05 UTC (History)
4 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Dan Ciarniello 2010-12-14 05:16:19 UTC
Version:           unspecified (using KDE 4.5.4) 
OS:                Linux

When the holiday region is set to Canada, holidays are displayed in French which is fine for French Canada but not for English Canada.

There should be either two Canadian holiday regions, one English and one French or there should be an option to select the desired language for the Canadian calendar (and any other country which has more than one official language)

Reproducible: Always

Steps to Reproduce:
Select holiday region Canada under Settings -> Configure Korganizer -> Time and Date

Actual Results:  
Canadian holidays displayed in French

Expected Results:  
Choice to display either in English or French

The KOrganizer version is 4.4.8 but that option is not available in the version drop down.
Comment 1 John Layt 2010-12-15 19:54:26 UTC
KHoliday does have separate files for Canada holidays in both English and French.  Unfortunately the KOrganizer interface doesn't offer both in the selection, unlike the Plasma Calendar, so what happens is it just picks up the first file it finds for ca which happens to be holidays_ca-qc_fr, i.e. the French file for Quebec.

I'm not sure if this has been fixed in 4.6 or not, but the fix is to either modify the current combo to be more intelligent like the Plasma calendar in 4.5, or use the new KHoliday::HolidaySelector widget from kdepimlibs in 4.6.  I _might_ be able to squeeze this in for 4.6 if I could get akonadi/nepomuk 4.6 to work in my dev build :-)
Comment 2 John Layt 2010-12-16 00:06:01 UTC
Heh, I was thinking this was familiar.  I did actually fix this for 4.5, I just clean forgot I had :-)  We never released 4.5 but in 4.6 this works fine.
Comment 3 Geordi LaForge 2011-02-10 00:08:44 UTC
Hy all,
i have the same problem on italian holidays...the problem is that there are two calendar, on for the italian and one for the Sudtirol, german language in italy...if i select italian, korganizer show me the german version...not good!

Distribution: Fedora 14
Korganizer: 4.4.9
Kde: 4.5.5

An idea when the fix will come in line?
The only temporay fix that i find is to remove the file /usr/share/kde4/apps/libkholidays/plan2/holiday_it-bz_de
Comment 4 John Layt 2011-02-10 02:23:00 UTC
We're waiting on KOrganizer 4.6 to be released.  Unfortunately it's not a feature that can be back-ported to 4.4, so deleting the other file is your only viable work-around until 4.6 is out.
Comment 5 Kevin Kofler 2011-02-10 09:11:46 UTC
I take it that the relevant commits are these?
http://quickgit.kde.org/index.php?p=kdepim.git&a=commit&h=12463515dd9a2410040cb76e62e9d52613632639
http://quickgit.kde.org/index.php?p=kdepim.git&a=commit&h=b08039d28337fb3ee4b77bd3d94e5e9faf11a71d
http://quickgit.kde.org/index.php?p=kdepim.git&a=commit&h=423fa0001a94431ec65f93ea53597d3d957b68a5

What's the minimum kdepimlibs for those? 4.5? 4.6? It can probably be backported in distros. Chances are most distros won't be picking up kdepim 4.6 for at least half a year to come.
Comment 6 Steve 2015-04-28 16:05:45 UTC
Being a KOrganizer noob, possibly I'm missing something; in "month" view, the calendar doesn't show the 4th of July. (Probably other holidays, but this is the first one I noticed)
Any ideas here, sports fans?