Bug 259757 - Small rendering issue in google chrome's toolbar
Summary: Small rendering issue in google chrome's toolbar
Status: CLOSED FIXED
Alias: None
Product: Oxygen
Classification: Plasma
Component: gtk2-engine (show other bugs)
Version: unspecified
Platform: Arch Linux Linux
: NOR normal
Target Milestone: ---
Assignee: Hugo Pereira Da Costa
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-12-13 19:53 UTC by Frederic Van Assche
Modified: 2011-07-29 23:40 UTC (History)
4 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Frederic Van Assche 2010-12-13 19:53:48 UTC
Version:           unspecified (using KDE 4.5.85) 
OS:                Linux

The bottom of Google Chrome's toolbar has a one pixel line separating it from the content below, but using the oxygen-gtk style, it is colored far too light.

I haven't tried changing my color scheme, though I am getting this issue with an unmodified oxygen cold scheme.

Example screenshots:

Using QtCurve: http://dl.dropbox.com/u/281677/qtcurve.png
Using Oxygen: http://dl.dropbox.com/u/281677/oxygen.png

Reproducible: Always
Comment 1 Frederic Van Assche 2010-12-13 19:59:38 UTC
Forgot to mention I'm using the 1.0.0 release of oxygen-gtk, but trying a git build at the time of submitting this bug yielded the same behavior.

Chrome version is the current dev build: 9.0.597.16
Comment 2 Hugo Pereira Da Costa 2010-12-13 20:17:23 UTC
Hehe. Truth is: I have no idea where this tiny line is rendered.
Current appearance is consistent with e.g. konqueror.
But not with firefox (who ignores the gtk style at many places anyway).
I'll dig a bit, and decide which convention to follow depending on what the code looks like :)
Comment 3 Frederic Van Assche 2010-12-13 22:58:56 UTC
I did some digging myself, and might have found where chrome(/ium) draws its toolbar separator:

http://www.google.com/codesearch/p?hl=en#OAMlx_jo-ck/src/chrome/browser/views/frame/opaque_browser_frame_view.cc&q=toolbar_separator&exact_package=chromium&sa=N&cd=8&ct=rc

...and I'm assuming it gets its color from here:

http://www.google.com/codesearch/p?hl=en#OAMlx_jo-ck/src/app/resource_bundle.cc&q=toolbar_separator&exact_package=chromium&sa=N&cd=2&ct=rc

However, that's not even close to the color I'm actually seeing. Fiddling with chrome themes doesn't change the separator at all.
I then turned the window background color of the oxygen cold theme pure red (my eyes!), after which a bright red separator line indicated that it might just not get drawn at all.

Hope this helps.
Comment 4 Frederic Van Assche 2010-12-13 23:16:27 UTC
I have found another rendering issue that might be related, or even an additional symptom of the same bug:

The download bar at the bottom of Google Chrome seemed off after switching to oxygen-gtk, but now I've figured out why:

QtCurve: http://dl.dropbox.com/u/281677/qtcurve-bottom.png
Oxygen:  http://dl.dropbox.com/u/281677/oxygen-bottom.png

It's not blue, and similar to the toolbar separator, the top border appears to be wrongly colored.

The blue tint is probably a QtCurve thing, as it stays grey using different GTK themes, though the border is only gone using oxygen-gtk.
Comment 5 Sergey Chebotar 2010-12-14 16:07:49 UTC
Yet another issue for Chrome. Border colors of the theme are ignored. For example:
QtCurve: http://ubuntuone.com/p/TdS/
Oxygen: http://ubuntuone.com/p/TdT/
Comment 6 Ruslan Kabatsayev 2011-01-20 23:04:42 UTC
It's definitely a Chromium's bug, not ours. We set the colors correctly, i believe.
Comment 7 Frederic Van Assche 2011-01-26 23:25:27 UTC
Fixed for me by a recent commit, probably 7ad04331b0aa71fade781ac9965451bec1201783.

Thanks :D