Bug 258428 - Kwin decorator doesn't change "always on top" icon when selected
Summary: Kwin decorator doesn't change "always on top" icon when selected
Status: RESOLVED WORKSFORME
Alias: None
Product: Oxygen
Classification: Plasma
Component: win deco (show other bugs)
Version: unspecified
Platform: Arch Linux Linux
: NOR minor
Target Milestone: ---
Assignee: Hugo Pereira Da Costa
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-11-30 20:48 UTC by Majki
Modified: 2023-01-17 05:18 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments
Buttons (9.45 KB, image/png)
2010-11-30 21:15 UTC, Hugo Pereira Da Costa
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Majki 2010-11-30 20:48:05 UTC
Version:           unspecified (using KDE 4.5.3) 
OS:                Linux

I have custom button layout on my kwin decoration. I use "always on top" setting very often. It'c indicated by icon (button), two little arrows pointg upwards. In KDE 4.4.X when I clicked it, button stared to glow, indicating that "always on top" for that one partiular window is on. Now it doesn't. But of course, window stays on top.

I'm using Oxygen window decorator theme.

Reproducible: Always

Steps to Reproduce:
1.In customizing window decoration options put button "always on top" on the window decorator.
2.Click it to enable "always on top" parameter.

Actual Results:  
Button stays the same.

Expected Results:  
Button begins to glow.

I'm using Oxygen window decorator theme.
Comment 1 Hugo Pereira Da Costa 2010-11-30 21:03:10 UTC
Definitely some sort of bug.
Will not make it glow when toggled, but appear sunken
(as is already the case for 'sticky' button).

Thanks for reporting.
Comment 2 Hugo Pereira Da Costa 2010-11-30 21:07:12 UTC
Actually, as far as I can tell, the effect I referred to (button remaining sunken), is already there in kde4.5 (and in trunk). Correct (see how the gradient changes between the pressed button and the others) ? 

If yes, I'll close the bug as invalid.
Comment 3 Majki 2010-11-30 21:10:42 UTC
(In reply to comment #2)
There is no difference in button layout currently.

Cheers.
Comment 4 Hugo Pereira Da Costa 2010-11-30 21:15:53 UTC
Created attachment 53918 [details]
Buttons

To comment #3
Screenshot attached is how it should look like (I checked with both 4.5.x and trunk). Left button is unpressed, right button is (and window is above others).
Is it not what yours look like ?
If not, please send screenshot
Comment 5 Majki 2010-11-30 21:22:55 UTC
(In reply to comment #4)
Oh! Hugo, now I see... 
http://a.yfrog.com/img641/19/buttonsx.png

But in day-to-day work it's almost invisible difference.
Comment 6 Hugo Pereira Da Costa 2010-12-01 11:29:37 UTC
I see. Indeed, the difference is quite subtle. 

I guess we could draw the icon with the "hover" color, but without the glow (as was the case in earlier kde versions for the sticky button), although strictly speaking this is breaking the meaning of colors in the colorscheme. (hover is for mouse-over effects; focus is for widgets with focus, so none of them applies to the case you describe). 

I'll discuss it on IRC.
Comment 7 Majki 2010-12-01 11:33:47 UTC
(In reply to comment #6)

You're the tech guys, You know better:) But please, do something:)
Comment 8 Hugo Pereira Da Costa 2010-12-07 19:08:10 UTC
SVN commit 1204518 by hpereiradacosta:

Remove usage of statically allocated Oxygen::StyleHelper.
The helper is now a member of Oxygen::Style.
CCBUG: 258428


 M  +277 -286  oxygenstyle.cpp  
 M  +5 -1      oxygenstyle.h  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1204518
Comment 9 Hugo Pereira Da Costa 2010-12-07 19:09:13 UTC
Ahhh fuck (pardon my French). Wrong ccbug.
Comment 10 Andrew Crouthamel 2018-11-05 03:19:55 UTC
Dear Bug Submitter,

This bug has been stagnant for a long time. Could you help us out and re-test if the bug is valid in the latest version? I am setting the status to NEEDSINFO pending your response, please change the Status back to REPORTED when you respond.

Thank you for helping us make KDE software even better for everyone!
Comment 11 Andrew Crouthamel 2018-11-17 05:02:36 UTC
Dear Bug Submitter,

This is a reminder that this bug has been stagnant for a long time. Could you help us out and re-test if the bug is valid in the latest version? This bug will be moved back to REPORTED Status for manual review later, which may take a while. If you are able to, please lend us a hand.

Thank you for helping us make KDE software even better for everyone!
Comment 12 Justin Zobel 2022-12-18 08:18:29 UTC
Thank you for reporting this issue in KDE software. As it has been a while since this issue was reported, can we please ask you to see if you can reproduce the issue with a recent software version?

If you can reproduce the issue, please change the status to "REPORTED" when replying. Thank you!
Comment 13 Bug Janitor Service 2023-01-02 05:26:42 UTC
Dear Bug Submitter,

This bug has been in NEEDSINFO status with no change for at least
15 days. Please provide the requested information as soon as
possible and set the bug status as REPORTED. Due to regular bug
tracker maintenance, if the bug is still in NEEDSINFO status with
no change in 30 days the bug will be closed as RESOLVED > WORKSFORME
due to lack of needed information.

For more information about our bug triaging procedures please read the
wiki located here:
https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging

If you have already provided the requested information, please
mark the bug as REPORTED so that the KDE team knows that the bug is
ready to be confirmed.

Thank you for helping us make KDE software even better for everyone!
Comment 14 Bug Janitor Service 2023-01-17 05:18:01 UTC
This bug has been in NEEDSINFO status with no change for at least
30 days. The bug is now closed as RESOLVED > WORKSFORME
due to lack of needed information.

For more information about our bug triaging procedures please read the
wiki located here:
https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging

Thank you for helping us make KDE software even better for everyone!