Bug 256174 - Build with Non-colocated Source and Build Directories Fails
Summary: Build with Non-colocated Source and Build Directories Fails
Status: RESOLVED DUPLICATE of bug 333628
Alias: None
Product: valgrind
Classification: Developer tools
Component: general (other bugs)
Version First Reported In: 3.6.0
Platform: Compiled Sources Linux
: NOR normal
Target Milestone: ---
Assignee: Julian Seward
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-11-05 19:09 UTC by Grant Erickson
Modified: 2014-05-09 16:24 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments
This patch fixes the fact that valgrind default suppression files are not conditioned based on whether they exist in the source directory or whether they are created anew in the build directory. (673 bytes, patch)
2010-11-05 19:09 UTC, Grant Erickson
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Grant Erickson 2010-11-05 19:09:17 UTC
Created attachment 53170 [details]
This patch fixes the fact that valgrind default suppression files are not conditioned based on whether they exist in the source directory or whether they are created anew in the build directory. 

Version:           3.6.0
OS:                Linux

When building valgrind-3.6.0 under ARM/Linux with non-colocated source and build directories, the build fails because the top-level generated make file cannot find most of the suppression files.

Reproducible: Always

Steps to Reproduce:
1. Unarchive the valgrind-3.6.0 archive.
2. Create a directory at the same level as the resulting valgrind-3.6.0 directory, called "build".
3. Change to the directory "build"
4. Run ../valgrind-3.6.0/configure
5. Type 'make' to begin the build.

Actual Results:  
The step where it runs 'cat $(DEFAULT_SUPP_FILES) >> default.supp fails with 'xfree-3.supp': No such file or directory", etc.

Expected Results:  
Each of these suppression files needs to be qualified or search for in both the source or build directory prior to cat'ing them.

The attached patch addresses the issue.
Comment 1 Peter Maydell 2010-11-08 08:42:12 UTC
NB that this is the first of the two issues noted in bug 232510 as preventing 'make distcheck' from working.
Comment 2 Mark Wielaard 2014-05-09 16:24:43 UTC
Sorry, I missed this bug earlier. Although this bug is older, the newer bug #333628 has a bit more details.

*** This bug has been marked as a duplicate of bug 333628 ***