Bug 256029 - passwords from kwallet are not used in WebKit view mode
Summary: passwords from kwallet are not used in WebKit view mode
Status: RESOLVED FIXED
Alias: None
Product: kdelibs
Classification: Unmaintained
Component: kdewebkit (show other bugs)
Version: 0.1
Platform: openSUSE Linux
: NOR normal
Target Milestone: ---
Assignee: webkit-devel
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-11-04 10:33 UTC by Silver Salonen
Modified: 2012-05-27 08:23 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In: 4.6.1
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Silver Salonen 2010-11-04 10:33:41 UTC
Version:           4.5.2 (using KDE 4.5.2) 
OS:                Linux

I have set WebKit as the default view mode. When I access a web-page I've saved information for in KWallet, the information is not retrieved. When I switch to KHTML view mode, the form is filled.

Reproducible: Always
Comment 1 Martin Tlustos 2011-01-28 11:11:30 UTC
Same here - quite disturbing...
Comment 2 Dawit Alemayehu 2011-01-28 16:24:12 UTC
I cannot reproduce this problem. Login information is filled correctly in both khtml and kwebkitpart correctly. 

The only way I could think this problem would exist is if the kwebkitpart installed on your system is a very very old one which does not have the support for KWallet. Can both of you verify what version of kwebkitpart is installed on your system ?
Comment 3 Silver Salonen 2011-01-30 20:32:54 UTC
I have kwebkitpart 1.1.0 installed. I also have KDE 4.6 now, but I just confirmed the same behaviour.
Comment 4 Dawit Alemayehu 2011-01-30 20:58:40 UTC
(In reply to comment #3)
> I have kwebkitpart 1.1.0 installed. I also have KDE 4.6 now, but I just
> confirmed the same behaviour.

Hmmm... no idea why that would be the case. It works fine here for me. Nothing related to the kwallet integration was changed in this release. Does this happen for every site that requires login or is it specific to particular sites ? Do you see any relevant error messages in your ~/.xsession-errors file ?
Comment 5 Silver Salonen 2011-01-30 21:44:09 UTC
I checked .xsession-error file, but I didn't notice anything interesting being logged in there while I opened a website in Konqueror.

And it does work for some websites though. I'm not sure about the success/fail ratio :)
Comment 6 Dawit Alemayehu 2011-01-30 21:52:24 UTC
(In reply to comment #5)
> I checked .xsession-error file, but I didn't notice anything interesting being
> logged in there while I opened a website in Konqueror.
> 
> And it does work for some websites though. I'm not sure about the success/fail
> ratio :)

Ahhh... It is entirely possible the KWallet support fails to work at some sites. Please provide the specific sites where this fails for you.
Comment 7 Silver Salonen 2011-01-31 08:14:41 UTC
One such site is not very public, so I'll send it to your e-mail ;)
Comment 8 Dawit Alemayehu 2011-01-31 16:27:37 UTC
(In reply to comment #7)
> One such site is not very public, so I'll send it to your e-mail ;)

Got your test site and I can duplicate the bug for that site and I am almost certain the others reporting here are encountering the issue because of similar conditions on other sites. Unfortunately the issue is upstream in QtWebKit. The API we use (QWebElement) does not correctly return the form <input> elements to be filled. Fortunately though we can and will provide a workaround for it in the next bug fix release of kdelibs.
Comment 9 Dawit Alemayehu 2011-02-01 00:16:18 UTC
Git commit 759c1cd0eb5da022e5cbb9bbeb5a8a1d984f3408 by Dawit Alemayehu.
Pushed by adawit into branch 'master'.

- Switched back to using javscript to parse forms for login information due to problems
  with QWebElement when form inputs are nested inside of a table row.

CCBUG: 256029
FIXED-IN: pending for v4.6.1

M  +179  -175  kdewebkit/kwebwallet.cpp     

http://commits.kde.org/kdelibs/759c1cd0eb5da022e5cbb9bbeb5a8a1d984f3408
Comment 10 Dawit Alemayehu 2011-02-03 04:31:31 UTC
Git commit 8b47a880ece1a41b6685b6b12a2074e8c3a9167d by Dawit Alemayehu.
Committed on 03/02/11 at 04:16.
Pushed by adawit into branch 'KDE/4.6'.

Switched back to using javscript to parse forms for login information due to problems
with QWebElement when form inputs are nested inside of a table row.

BUG: 256029
FIXED-IN: 4.6.1

M  +182  -175  kdewebkit/kwebwallet.cpp     

http://commits.kde.org/kdelibs/8b47a880ece1a41b6685b6b12a2074e8c3a9167d
Comment 11 Stanislav Sidorenko 2012-05-27 07:42:45 UTC
Looks like this issue is still not fixed in KDE 4.8.3, see bug 298372
Comment 12 Dawit Alemayehu 2012-05-27 08:23:01 UTC
(In reply to comment #11)
> Looks like this issue is still not fixed in KDE 4.8.3, see bug 298372

Yes, it is fixed. Please do not conflate bug reports together. This particular bug as reported has been fixed. No matter how similar your problem might seem to be to this bug report, it most definitely is not caused by the same thing. Otherwise, it would have been fixed by the change applied in comment #9.