Bug 255800 - "find in files" for a string ending in an LF character matches all lines, potentially resulting in bad performance.
Summary: "find in files" for a string ending in an LF character matches all lines, pot...
Status: RESOLVED WORKSFORME
Alias: None
Product: kdevplatform
Classification: Developer tools
Component: grepview (show other bugs)
Version: unspecified
Platform: Debian testing Linux
: NOR normal
Target Milestone: ---
Assignee: kdevelop-bugs-null
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-11-01 12:15 UTC by Diggory Hardy
Modified: 2023-02-03 05:02 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Diggory Hardy 2010-11-01 12:15:36 UTC
Version:           4.0.1 (using KDE 4.4.5) 
OS:                Linux

As subject line/below.

I'm not entirely sure if bad argument passing to xargs or an external bug is to blame, but a symptom of this is that the "find in files" result window can easily be filled with huge volumes of output making kdevelop respond very poorly (possibly just while the output is being copied to this frame; not sure). Thus it would be a good idea additionally to have a restriction on the amount of content that this frame can take or a warning with an option to abort when too much content is injected (can't give much info on a sensible limit, sorry).

Reproducible: Always

Steps to Reproduce:
Search in all files for any string ending with an LF (0x0A) character (warning: I'd advise picking a directory to search in containing only a few files to avoid the responsiveness issues described above).

Actual Results:  
All lines of all files are found, resulting in a lot of output and poor performance of kdevelop.

Expected Results:  
Some kind of catch to prevent such unresponsive behaviour, and either for the bad (multiline) regular expression to result in an error message rather than incorrect matches or for it to match across lines properly.
Comment 1 Gregor Mi 2014-09-21 10:57:36 UTC
I can confirm this with kdevelop 4.7 in a similar scenario:

I accidentally forget to put the build directory in the Exclude list of File Files dialog. So the search result includes an .so file which results in garbage unicode letter printed in the results view and kdevelop stops responding. I had to kill it.
Comment 2 Gregor Mi 2014-09-21 11:02:01 UTC
screenshot of garbage binary output: http://wstaw.org/m/2014/09/21/plasma-desktopOs2057.png
Comment 3 Andrew Crouthamel 2018-11-12 02:55:58 UTC
Dear Bug Submitter,

This bug has been stagnant for a long time. Could you help us out and re-test if the bug is valid in the latest version? I am setting the status to NEEDSINFO pending your response, please change the Status back to REPORTED when you respond.

Thank you for helping us make KDE software even better for everyone!
Comment 4 Andrew Crouthamel 2018-11-21 04:24:37 UTC
Dear Bug Submitter,

This is a reminder that this bug has been stagnant for a long time. Could you help us out and re-test if the bug is valid in the latest version? This bug will be moved back to REPORTED Status for manual review later, which may take a while. If you are able to, please lend us a hand.

Thank you for helping us make KDE software even better for everyone!
Comment 5 Justin Zobel 2023-01-04 07:05:24 UTC
Thank you for reporting this issue in KDE software. As it has been a while since this issue was reported, can we please ask you to see if you can reproduce the issue with a recent software version?

If you can reproduce the issue, please change the status to "REPORTED" when replying. Thank you!
Comment 6 Bug Janitor Service 2023-01-19 05:12:54 UTC
Dear Bug Submitter,

This bug has been in NEEDSINFO status with no change for at least
15 days. Please provide the requested information as soon as
possible and set the bug status as REPORTED. Due to regular bug
tracker maintenance, if the bug is still in NEEDSINFO status with
no change in 30 days the bug will be closed as RESOLVED > WORKSFORME
due to lack of needed information.

For more information about our bug triaging procedures please read the
wiki located here:
https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging

If you have already provided the requested information, please
mark the bug as REPORTED so that the KDE team knows that the bug is
ready to be confirmed.

Thank you for helping us make KDE software even better for everyone!
Comment 7 Bug Janitor Service 2023-02-03 05:02:42 UTC
This bug has been in NEEDSINFO status with no change for at least
30 days. The bug is now closed as RESOLVED > WORKSFORME
due to lack of needed information.

For more information about our bug triaging procedures please read the
wiki located here:
https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging

Thank you for helping us make KDE software even better for everyone!