Created attachment 52713 [details] sftp_async_read patch by Philip Lorenz Version: SVN (using Devel) OS: Linux Use sftp_async_read to speed up get requests The attached patch uses sftp_async_read to speed up the sftp kioslave. Preliminary testing showed that the transfer speed locally increased from ~3MByte/s to 18-20 MByte/s. It should apply cleanly to trunk (r1152597) but was developed against the KDE 4.5 branch. Let me know if there are any issues with the patch and I will try to fix them. Reproducible: Always
I'm working on this. I will push it as soon as I did more testing and the kde-runtime git repository is working correctly.
Git commit 8eaeb42c787c182b046ce78e5bcdc4069e68c2bb by Andreas Schneider. Committed on 30/01/11 at 21:15. Pushed by anschneider into branch 'master'. kio_sftp: Added async sftp download support. Thanks to Philip Lorenz. BUG: 254865 M +140 -15 kioslave/sftp/kio_sftp.cpp M +56 -1 kioslave/sftp/kio_sftp.h http://commits.kde.org/kde-runtime/8eaeb42c787c182b046ce78e5bcdc4069e68c2bb
Wow, the performance gains are very nice, and kind-of explain why kio_sftp was slower than other sftp/scp clients. Can this "fix" be backported for 4.6? Thanks.
thanks for fixing this. i'm not too sure how to test for this but is this related at all to this bug? https://bugs.kde.org/show_bug.cgi?id=264557
(In reply to comment #4) > thanks for fixing this. i'm not too sure how to test for this but is this > related at all to this bug? https://bugs.kde.org/show_bug.cgi?id=264557 No this is not related to that bug. The patch merely improved transfer speeds for the SFTP kioslave.
+1 to: Can this "fix" be backported for 4.6? Thanks.
I've asked when I pushed the patch and the answer was no backport as this is a new feature. So this will probably be not in any 4.6 release. We've reached libssh 0.5 and the plan is to support async sftp_read and sftp_write soon. So I hope we will have libssh 0.6 soon.
(In reply to comment #7) > I've asked when I pushed the patch and the answer was no backport as this is a > new feature. So this will probably be not in any 4.6 release. > > We've reached libssh 0.5 and the plan is to support async sftp_read and > sftp_write soon. So I hope we will have libssh 0.6 soon. Oh, it's a pity. I think this can be seen as a bug fix, as in "kio_sftp has bad performance, this fixes it", and it sucks having to wait 6 months for it, but thanks for trying and for all your hard work.
And what about folder async listing (because it's vey slow), it's fixed too with this patch?
*** Bug 218798 has been marked as a duplicate of this bug. ***
Has this patch been applied? I ask because something weird happened after my last upgrade to kde 4.6.5. Now my sftp upload ove 1gps link goes at about 1MB/sec. YES, about 100 times slower the theoretical limit. Thunar copies the same file to the same server at about 50MB/Sec. And as 218845 (KIO sftp:/ Slow in KDE 4) is marked as duplicate for 218845 (kio_sftp is much slower than command line scp) which is duplicate of this bug, i reported it here.
The patch has been applied and will be part of KDE 4.7.
Ok, going to open another bug report, thanks.
(In reply to comment #6) > +1 to: > Can this "fix" be backported for 4.6? Thanks. +1 :-)