Bug 254178 - Flake shapes are duplicated in the overlay
Summary: Flake shapes are duplicated in the overlay
Status: RESOLVED FIXED
Alias: None
Product: krita
Classification: Applications
Component: General (show other bugs)
Version: git master (please specify the git hash!)
Platform: Unlisted Binaries Linux
: NOR major
Target Milestone: ---
Assignee: Dmitry Kazakov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-10-14 18:03 UTC by Dmitry Kazakov
Modified: 2010-10-23 23:05 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:

Attachments
Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Dmitry Kazakov 2010-10-14 18:03:37 UTC 
Version:           svn trunk
OS:                Linux

1) Create the following image

-- paintLayer2
-- groupLayer
-- paintLayer1

2) Drag and drop a shape to the image. A new shape layer will be created.
3) Drag this new shape layer into the group layer

-- paintLayer2
-- groupLayer
   +- shapeLayer
-- paintLayer1

4) The shape will be painted in two places: shapeLayer's projection and in the overlay, so the shape will be painted above the paintLayer2.

Reproducible: Didn't try
Comment 1 Dmitry Kazakov 2010-10-23 23:05:39 UTC 
SVN commit 1189045 by dkazakov:

Fix Shape Layers

This patch fixes many bugs in shape layers. It consists of two small
parts: the first makes KisBaseNode::visible() recursive, the second
brings order to KisShapeController.

BUG:252451,253766,254178


 M  +7 -3      image/kis_base_node.cpp
 M  +15 -2     image/kis_base_node.h
 M  +5 -0      image/kis_node.cpp
 M  +2 -0      image/kis_node.h
 M  +0 -1      ui/CMakeLists.txt
 M  +5 -1      ui/canvas/kis_canvas2.cpp
 D             ui/flake/kis_layermap_visitor.cpp
 D             ui/flake/kis_layermap_visitor.h
 M  +0 -1      ui/flake/kis_node_shape.cpp
 M  +101 -236  ui/flake/kis_shape_controller.cpp
 M  +6 -13     ui/flake/kis_shape_controller.h
 M  +60 -3     ui/flake/kis_shape_layer.cc
 M  +9 -1      ui/flake/kis_shape_layer.h
 M  +9 -1      ui/flake/kis_shape_selection.h
 M  +2 -0      ui/tests/kis_shape_controller_test.cpp
 M  +10 -16    ui/tool/kis_selection_tool_helper.cpp


http://websvn.kde.org/?view=rev&revision=1189045