Bug 253459 - string "Undo" is used for both unavailable and available menu item
Summary: string "Undo" is used for both unavailable and available menu item
Status: RESOLVED UPSTREAM
Alias: None
Product: kdelibs
Classification: Unmaintained
Component: kdeui (show other bugs)
Version: 4.5
Platform: Gentoo Packages Linux
: NOR normal
Target Milestone: ---
Assignee: kdelibs bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-10-07 01:05 UTC by Alexander Potashev
Modified: 2011-04-25 20:15 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:

Attachments
Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Alexander Potashev 2010-10-07 01:05:25 UTC 
Version:           4.5 (using KDE 4.5.1) 
OS:                Linux

I would like to translate "Undo" as "Undo action" (but in Russian) when there are no commands to undo, and "Undo" (or "Undo %1") when there is one.

The same string is used in both cases:
#: kdeui/util/kundostack.cpp:67 kdeui/util/kkeyserver_x11.cpp:106
msgid "Undo"


The most horrible about this is that you can't use Trascript (translation scripting), because the name of the action does not go into the final menu item through a "%1". It probably just appends to the plain "Undo" string.

Reproducible: Always
Comment 1 Christoph Feck 2010-10-10 03:16:31 UTC 
> It probably just appends to the plain "Undo" string.

This is a problem in QUndoStack. The method that creates the "Undo" action really just prepends the prefix (usually "Undo") in front of the action text.

See http://doc.qt.nokia.com/latest/qundostack.html#createUndoAction
Comment 2 Christoph Feck 2010-10-13 14:25:37 UTC 
The second "Undo" string you mention is actually a key name, only present on SUN compiles. What to do about this bug? Do you want to report it upstream to Nokia developers?
Comment 3 Alexander Potashev 2010-10-13 18:47:26 UTC 
I've just reported this at the Qt bugtracker:
http://bugreports.qt.nokia.com/browse/QTBUG-14442
Comment 4 Alexander Potashev 2011-04-25 20:15:43 UTC 
For those who didn't read this:
http://lists.kde.org/?l=kde-core-devel&m=130375520919536&w=2