Bug 253339 - hiding menubar icons
Summary: hiding menubar icons
Status: RESOLVED FIXED
Alias: None
Product: kdelibs
Classification: Unmaintained
Component: kdeui (show other bugs)
Version: unspecified
Platform: Unlisted Binaries Linux
: NOR wishlist
Target Milestone: ---
Assignee: kdelibs bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-10-05 22:09 UTC by Bartemius Crouch
Modified: 2010-11-09 20:58 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Bartemius Crouch 2010-10-05 22:09:33 UTC
Version:           unspecified (using KDE 4.5.1) 
OS:                Linux

I'm sorry for my English, I know it's a stupid request but do it anyway. I can not explain why they can hide icons on the buttons and the toolbar but not in the menubar, I find that the menubar is more elegant without icons, is a questions of taste, however, a user should be able to choose. I would be very grateful if you heard this stupid whim.

Reproducible: Didn't try
Comment 1 Bartemius Crouch 2010-10-05 22:21:54 UTC
I was wrong,  I thought I had put whish
Comment 2 Christoph Feck 2010-10-05 23:26:35 UTC
Apart from the visual clutter that menu icons might produce for some users, it can also speed up initial menu usage because it does not need to load the icons.

The hiding of icons in the pull-down or pop-up menus is a feature of the style, as such I am reassigning to Oxygen/style, assuming that you are using the Oxygen widget style.
Comment 3 Bartemius Crouch 2010-10-06 11:53:47 UTC
Thank you for correcting the messages. Yes the style is oxygen, I do not know whether it is a problem of oxygen style, also because going in System Setting → Style → Fine Tuning, you can hide the icons (toolbar, buttons) in any style except for the menubar, then I do not know if the problem is with oxygen, but is more generally any style.
Comment 4 Hugo Pereira Da Costa 2010-10-06 19:47:26 UTC
mmm. Right now, oxygen does _not_ allow to hide icons in either the menubars and the menu. Will consider, but having icons has a purpose I must say.
I do believe that putting icons in MenuBars looks somewhat awkward to me, but thats more an application issue than a style issue.
(most applications don't do that, right ?)

Can you point me to one app that puts icons in toolbars ? 
Thanks in advance, 

Hugo
Comment 5 Bartemius Crouch 2010-10-07 12:05:11 UTC
I think that in your question you would say menubar and not toolbar, however in all applications there are icons in the menubar, of course, some menu item did not, but they are rare. The only application that did not have many icons in the menu is quassel irc. I recently tried Ubuntu in VirtualBox and I noticed that there are no icons in the menubar, I find it very clean and elegant in that way, I wish the same happens in kde. I also do not think it's a matter of style and oxygen, I'd like to see a fine tuning option that allows you to hide icons from the menubar, as is now done for the buttons and the toolbar. Thanks for taking my request into consideration.
Comment 6 Hugo Pereira Da Costa 2010-10-07 16:10:31 UTC
> 2010-10-07 12:05:11 --- I think that in your question you would say
> menubar and not toolbar, however in all applications there are icons in
> the menubar, of course, some menu item did not, but they are rare. The
> only application that did not have many icons in the menu is quassel irc.
> I recently tried Ubuntu in VirtualBox and I noticed that there are no
> icons in the menubar, I find it very clean and elegant in that way, I wish
> the same happens in kde. I also do not think it's a matter of style and
> oxygen, I'd like to see a fine tuning option that allows you to hide icons
> from the menubar, as is now done for the buttons and the toolbar. Thanks
> for taking my request into consideration.
So the way I unserstand right you're talking about icons in 'menu', not 
menubars (the bar usually located above the toolbar, in the main window). 
Correct ?
Comment 7 Bartemius Crouch 2010-10-07 17:44:04 UTC
I'm talking about the icons of the menu pop-up contained in the menubar, to understand those icons near to items such: about kde, report bug, quit, etc. I wish I could hide those icons.
Comment 8 Hugo Pereira Da Costa 2010-10-07 18:31:27 UTC
yes thats clear. Bespin does that, so I guess oxygen can too.
Although I would rather have it as an independent option, located at the same place as the 'show icons in buttons', that styles may or may not honor, rather than a fine tuning in oxygen.

Christoph ? What do you think ?
Comment 9 Christoph Feck 2010-10-10 14:02:01 UTC
Actually you do not need to change anything in Oxygen. Qt menus respect the Qt::AA_DontShowIconsInMenus attribute, and KApplication can make that configurable.
Comment 10 Christoph Feck 2010-11-09 20:46:36 UTC
SVN commit 1194750 by cfeck:

Allow to hide menu icons

I tested this for three weeks, and when I wanted to revert to the
old behavior, I was really shocked how cluttered the menus look
with icons :)

There are only two places, where I initally missed the icons:
- "Classic" KDE menu
- Konqueror Bookmarks menu

For those places, we could request icons by using the QAction
property, but this probably has to discussed with users.

Actually, I now like the classic menu not showing icons,
because it opens much faster without them. The bookmark
menu never was a problem speedwise.

See http://svn.reviewboard.kde.org/r/5609/
FEATURE: 253339
GUI:


 M  +22 -2     kdebase/workspace/kcontrol/style/finetuning.ui  
 M  +13 -0     kdebase/workspace/kcontrol/style/kcmstyle.cpp  
 M  +2 -0      kdelibs/kdeui/kernel/kglobalsettings.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1194750
Comment 11 Christoph Feck 2010-11-09 20:58:43 UTC
Hugo, you can decide if you want to "remove the empty gap" that the icons previously occupied. But beware that specific actions can force icons despite the global QApplication setting. QStyleOptionMenuItem has a maxIconWidth property, I think this is 0 when there are no icons on the whole menu.