Bug 253258 - Comment id3v2 tag is not written in the same way as it's read
Summary: Comment id3v2 tag is not written in the same way as it's read
Status: RESOLVED WORKSFORME
Alias: None
Product: taglib
Classification: Frameworks and Libraries
Component: general (show other bugs)
Version: 1.6.3
Platform: macOS (DMG) macOS
: NOR normal
Target Milestone: ---
Assignee: Scott Wheeler
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-10-04 21:02 UTC by tobias
Modified: 2023-01-18 05:12 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description tobias 2010-10-04 21:02:57 UTC
Version:           1.6.3 (using Devel) 
OS:                OS X

While parsing an AIFF file with the taglib library on Mac OS X I noticed a file holding more than one COMM frame, 3-unknown frames. When I inserted the file into iTunes and set a new comment for the file, another frame was created by iTunes. When I read it with the taglib it showed up the right way, the last COMM frame was used. When trying to change that value, the first COMM frame (which was a Null) in this case, was overwritten. What that means is I set a new comment and reloaded but since the LAST frame is read, it was always showing the one iTunes created but couldn't edit it. The 'comment' and 'setComment' methods must operate in the same way. The issue lies right here in this line:

d->frameListMap["COMM"].front()->setText(s);

This means always the first COMM frame found will be set. BUT when looking back at the reading method, it's iterating through all the frames:

for(FrameList::ConstIterator it = comments.begin(); it != comments.end(); ++it)
  {
    CommentsFrame *frame = dynamic_cast<CommentsFrame *>(*it);

    if(frame && frame->description().isEmpty())
	{
	
      return (*it)->toString();
	}
  }


Is there an explanation for this behavior or is it really a bug?

Best regards,
TJ.

Reproducible: Always

Steps to Reproduce:
Take an AIFF file which somehow holds more than one COMM frame and make iTunes create one at the end. Then try reading it (you'll see the itunes frame) and try to overwrite that comment and you'll notice it's overwriting the first COMM frame, not the last one from iTunes.

Actual Results:  
Unable to change the COMM frame created by iTunes.

Expected Results:  
Change the last COMM frame.
Comment 1 Andrew Crouthamel 2018-11-05 03:17:50 UTC
Dear Bug Submitter,

This bug has been stagnant for a long time. Could you help us out and re-test if the bug is valid in the latest version? I am setting the status to NEEDSINFO pending your response, please change the Status back to REPORTED when you respond.

Thank you for helping us make KDE software even better for everyone!
Comment 2 Andrew Crouthamel 2018-11-17 05:04:48 UTC
Dear Bug Submitter,

This is a reminder that this bug has been stagnant for a long time. Could you help us out and re-test if the bug is valid in the latest version? This bug will be moved back to REPORTED Status for manual review later, which may take a while. If you are able to, please lend us a hand.

Thank you for helping us make KDE software even better for everyone!
Comment 3 Justin Zobel 2022-12-19 00:13:21 UTC
Thank you for reporting this issue in KDE software. As it has been a while since this issue was reported, can we please ask you to see if you can reproduce the issue with a recent software version?

If you can reproduce the issue, please change the status to "REPORTED" when replying. Thank you!
Comment 4 Bug Janitor Service 2023-01-03 05:27:16 UTC
Dear Bug Submitter,

This bug has been in NEEDSINFO status with no change for at least
15 days. Please provide the requested information as soon as
possible and set the bug status as REPORTED. Due to regular bug
tracker maintenance, if the bug is still in NEEDSINFO status with
no change in 30 days the bug will be closed as RESOLVED > WORKSFORME
due to lack of needed information.

For more information about our bug triaging procedures please read the
wiki located here:
https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging

If you have already provided the requested information, please
mark the bug as REPORTED so that the KDE team knows that the bug is
ready to be confirmed.

Thank you for helping us make KDE software even better for everyone!
Comment 5 Bug Janitor Service 2023-01-18 05:12:19 UTC
This bug has been in NEEDSINFO status with no change for at least
30 days. The bug is now closed as RESOLVED > WORKSFORME
due to lack of needed information.

For more information about our bug triaging procedures please read the
wiki located here:
https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging

Thank you for helping us make KDE software even better for everyone!