Bug 252799 - After successful export of photo it should not be exported again.
Summary: After successful export of photo it should not be exported again.
Status: RESOLVED FIXED
Alias: None
Product: digikam
Classification: Applications
Component: Plugin-WebService-Google (show other bugs)
Version: unspecified
Platform: Arch Linux Linux
: NOR normal
Target Milestone: ---
Assignee: Digikam Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-09-29 22:20 UTC by Oleg Atamanenko
Modified: 2018-01-30 21:23 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In: 1.5.0


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Oleg Atamanenko 2010-09-29 22:20:56 UTC
Version:           1.1.0 (using KDE 4.5.1) 
OS:                Linux

This issue is regarding usability.



Reproducible: Always

Steps to Reproduce:
1. Add photo to Picase Export by pressing alt+shift+p
2. Switch to upload dialog, press upload button.
3. Switch back to digikam/gwenview
4. Add another photo to export dialog.
5. Switch to upload dialog, press upload button.

Actual Results:  
6a. Already uploaded first photo is uploaded again and fails with duplicate photo exception. All next photos are not processed.

Expected Results:  
6b. Already uploaded photo(s) skipped, uploading only new photos.

Maybe it is better to automatically remove successfully loaded photos from upload queue.
Comment 1 caulier.gilles 2010-09-30 08:40:16 UTC
Update to last kipi-plugins 1.4.0. Jens has rewritten this plugin.

Gilles Caulier
Comment 2 Oleg Atamanenko 2010-09-30 09:32:14 UTC
I reported incorrect version of kipi-plugins. I checked version of my kipi-plugins, it is 1.4.0. :

[uthark@solweig-notebook ~] 5900% LANG=C pacman -Qi kipi-plugins
Name           : kipi-plugins
Version        : 1.4.0-1
URL            : http://www.kipi-plugins.org
Licenses       : GPL
Groups         : None
Provides       : None
Depends On     : kdegraphics-libs  kdepimlibs  opencv  libgpod
Optional Deps  : imagemagick: for picture manipulation
                 qca: for shwup webservice support
Required By    : None
Conflicts With : None
Replaces       : None
Installed Size : 18156.00 K
Packager       : Tobias Powalowski <tpowa@archlinux.org>
Architecture   : i686
Build Date     : Thu Aug 26 17:14:39 2010
Install Date   : Sun Aug 29 17:28:48 2010
Install Reason : Explicitly installed
Install Script : Yes
Description    : libkipi plugins for digikam and kde apps
Comment 3 Jens Mueller 2010-09-30 20:13:45 UTC
From my opinion processed items should'nt be removed from queue, as you don't see status of items then, second the behaiviour of all plugins should be the same. But I agree that there is a usability bug as you reported.

About your actual results: You say all further items are not processd. I assume that you clicked on 'Cancel' on the messagebox. Cancel means Abort (perhaps it should be named so), you also have the possibilities to 'Skip' and 'Replace'. In both cases the other items of your queue will be processed afterwards.

One more notice: Closing the pluin after upload will put your next item to an empty queue.

So the question is: if we do not reupload already processed items of a queue, what is the expected behaviour if you add a already uploaded item again:

1. nothing will be done

2. the status of the existing item will change and it will be uploaded again

3. a new upload item will be created

4. this depends on modification state. But this will be oversized, I think.

Notice: currently it is impossible to add the same item twice.
Comment 4 Oleg Atamanenko 2010-09-30 20:38:43 UTC
My opinion is that nothing should be done.

About closing window - have often do not close plugin window, I add several photos, then click upload in the plugin window, switch back to digikam and continue to add pictures (I'm using keyboard shortcut). So for me it good, when plugin is smart enough and doesn't try to reupload successfully uploaded items.

About your last notice - when I add photo, upload it, then add another photo without removing first from the queue and try upload, plugin tries to upload first photo again - this is what I don't want from plugin to do.

Also, if photo was successfully uploaded, then *for me* it is ok, if it is removed from *upload queue*. :) Because it was uploaded.
Comment 5 Jens Mueller 2010-10-01 20:57:54 UTC
SVN commit 1181681 by jmueller:

Do not reupload already processed items.

BUGS: 252799

 M  +2 -1      NEWS  
 M  +15 -1     common/libkipiplugins/widgets/imageslist.cpp  
 M  +10 -1     common/libkipiplugins/widgets/imageslist.h  
 M  +1 -1      picasawebexport/picasawebwindow.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1181681