Bug 252355 - configuration: can't add/remove properties for actions
Summary: configuration: can't add/remove properties for actions
Status: REOPENED
Alias: None
Product: frameworks-solid
Classification: Frameworks and Libraries
Component: general (show other bugs)
Version: unspecified
Platform: Debian testing Linux
: NOR wishlist
Target Milestone: ---
Assignee: Lukáš Tinkl
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-09-25 17:30 UTC by Eckhart Wörner
Modified: 2015-03-12 11:34 UTC (History)
4 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Eckhart Wörner 2010-09-25 17:30:20 UTC
Version:           unspecified (using KDE 4.5.1) 
OS:                Linux

This bug has been copied over from
http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=597638

----

This is about the configuration dialog for editing
an action what is offered to a device (eg open with file manager)

The dialog only offers to edit the parameters already there
but not to add a new parameter or remove an existing one.
In particular, I don't see the "+" and "-" buttons to do these.

Best wishes,

	Gábor Braun

Reproducible: Always

Steps to Reproduce:
Open the device notifier configuration, category device actions, select an action then edit the action.
Comment 1 Aaron J. Seigo 2010-09-26 21:17:47 UTC
this is part of solid; the device notifier simply integrates it into its configuration dialog.
Comment 2 Ben Cooksley 2010-09-26 21:40:30 UTC
Please read the module documentation.

Device parameters must be either a Conjunction or Disjunction to have children items, and must have 2 children only ( not any other number ). As such, when changing the type, the module automatically adds the two children.
Comment 3 Eckhart Wörner 2010-09-26 23:23:50 UTC
(In reply to comment #2)
> Device parameters must be either a Conjunction or Disjunction to have children
> items, and must have 2 children only ( not any other number ). As such, when
> changing the type, the module automatically adds the two children.

Sorry, but this is a highly technical approach to the problem. Of course it is possible to represent every possible formula through a full binary tree, but this is totally non-intuitive:
- the user only sees that he can create sub-clauses when clicking the "Save Parameter Changes" button. Sure, it's in the docu, but who reads the docu?
- the conjunction property (?) is labelled "All of the contained properties must match", which reads as if it was possible to have more than two contained properties. I probably would have expected "Both contained properties must match"
- users don't think in "let's create a conjunction of two properties where the first property is a conjunction of two properties and the second conjunction is a conjunction of two properties", but in "let's create a conjunction of four properties".

Also, since this is a wish, closing as INVALID is a bit weird. The wish in itself is perfectly fine.
Comment 4 Ben Cooksley 2010-09-26 23:44:51 UTC
It is simply technically impossible to complete the wish, without altering the Solid Predicate language, which is located in kdelibs, and therefore subject to Compatibility constraints.

The only other way to implement it would be by placing some form of a compatibility layer on top, which would be a hack, highly unreliable, and subject to generating invalid predicates.

Adding Solid maintainer.
Comment 5 Jonathan Riddell 2015-03-11 19:04:00 UTC
This bug is reported on libsolid which is the kdelibs4 version of the solid library.  It is now in maintenance mode.  If you think it should still be fixed in the KDE Frameworks 5 version of solid please move it to or report a bug on frameworks-solid.