Bug 252319 - BOM not detected by Kate
Summary: BOM not detected by Kate
Status: RESOLVED FIXED
Alias: None
Product: kate
Classification: Applications
Component: encoding (show other bugs)
Version: unspecified
Platform: Arch Linux Linux
: NOR minor
Target Milestone: ---
Assignee: KWrite Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-09-25 11:32 UTC by Ido Kanner
Modified: 2012-11-01 15:11 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Ido Kanner 2010-09-25 11:32:38 UTC
Version:           unspecified (using KDE 4.5.1) 
OS:                Linux

My session is configured not to add by default BOM to a file, but when I opened a UTF-8 files with BOM, the menu option of "Tools->Add Byte Order Mark (BOM)" was unchecked, even tough that using od, I could see the BOM marks.

If I mark the menu option it will not add the BOM itself again (as expected), and unmark it, does remove the BOM.

The expected behavior is that the menu option will be set if there is a BOM.

Reproducible: Always

Steps to Reproduce:
1. Open a file with UTF-8 BOM (did not try other encoding) that was not added by the session of Kate.
2. View the menu item of "Tools->Add Byte Order Mark (BOM)" and see if it's checked or not.

Actual Results:  
The menu option is not checked

Expected Results:  
The menu option should be checked if there is an existed BOM in the text file.

I'm using Kate 3.5.1 in Arch Linux.
As I said, I only tested it with UTF-8, and when the session configuration does not configured to add BOM by default.
Comment 1 Christoph Cullmann 2012-11-01 15:11:16 UTC
Git commit 5525fd1e31b9a7286d235b0ef262d051053678f4 by Christoph Cullmann.
Committed on 01/11/2012 at 16:10.
Pushed by cullmann into branch 'master'.

enforce right default value of bom checkbox
looks ok here, files with detected bom gets marked with it in menu

M  +1    -0    part/view/kateview.cpp

http://commits.kde.org/kate/5525fd1e31b9a7286d235b0ef262d051053678f4