Bug 252134 - when selecting multiple images, some controls should be disabled
Summary: when selecting multiple images, some controls should be disabled
Alias: None
Product: digikam
Classification: Applications
Component: Albums-MainView (show other bugs)
Version: 1.3.0
Platform: Ubuntu Linux
: NOR wishlist
Target Milestone: ---
Assignee: Digikam Developers
Depends on:
Reported: 2010-09-23 14:38 UTC by Simon Oosthoek
Modified: 2012-06-27 10:28 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In: 2.0.0


Note You need to log in before you can comment on or make changes to this bug.
Description Simon Oosthoek 2010-09-23 14:38:25 UTC
Version:           1.3.0 (using KDE 4.5.1) 
OS:                Linux

Whenever I select a bunch of images (using either shift or ctrl + mouseclick) I sometimes click on a part of an image-thumbnail where a control is hidden, like rotate image or rate image.

There are two problems with this:
1) when I select multiple images, I don't think I ever want to use these controls
2) since the controls are hidden unless the mouse hovers over the thumbnail, it's easy to click in a place where a control will appear only when the mouse hovers over it.
( 3) I get really cautious about clicking anywhere, since something undesirable might happen)

Would it be easy to only show/enable the rotate/rate controls when no other images are selected _or_ when the result of the click would cause no more than that image to be selected (subtle difference that ;-)

And most certainly disable the controls when I have either ctrl or shift pressed.

Reproducible: Always

Steps to Reproduce:
in an album, select first one image, then, while holding shift or ctrl, select another image, but click on the rotate left or right button that appears only when you hover over the thumbnail.

Actual Results:  
the last image clicked will not only extend the selection range, but also be rotated

Expected Results:  
only the selection range should be extended
Comment 1 Marcel Wiesweg 2010-09-23 18:44:14 UTC
I can agree with this idea:
Dont show overlays - except +/- - when pressing SHIFT or CTRL

I disagree about hiding the overlays on multiple selection. Rather, I see it as a usability problem that the action taken only affects the immediate image instead of the full selection.
It's a general problem that the overlays graphically refer to a single item, but it's a common case to apply the operation to the full selection. That means in case of multiple selection, the overlays would need a graphical hint at operating on the full selection. I've been thinking about this for some time.
Comment 2 Marcel Wiesweg 2011-07-11 17:03:02 UTC
Git commit f4d52daa980d4711607a79b209788b5c1988f24c by Marcel Wiesweg.
Committed on 01/07/2011 at 18:17.
Pushed by mwiesweg into branch 'master'.

Do not show overlays when Ctrl or Shift are pressed.
This agrees with other behavior, such as disabling the View action.

BUG: 252134

M  +15   -2    libs/widgets/common/imagedelegateoverlay.cpp     

Comment 3 Marcel Wiesweg 2011-07-11 17:03:41 UTC
Note: since some time, overlays apply  to all selected images.
This is indicated by a tooltip-like message "Operation applied to n images"