Bug 251914 - KNotes dbus interface missing notes() as compared to old dcop interface
Summary: KNotes dbus interface missing notes() as compared to old dcop interface
Status: RESOLVED FIXED
Alias: None
Product: knotes
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: openSUSE Linux
: NOR normal
Target Milestone: ---
Assignee: kdepim bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-09-21 12:25 UTC by Tejas Guruswamy
Modified: 2010-09-27 00:56 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:

Attachments
Patch restoring notes() method to knotes (1.54 KB, patch)
2010-09-21 12:26 UTC, Tejas Guruswamy 		Details
View All Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Tejas Guruswamy 2010-09-21 12:25:18 UTC 
Version:           unspecified (using KDE 4.5.1) 
OS:                Linux

KNotes dbus interface is missing the notes() method as compared to the old dcop interface, making it impossible to get note id's.
This is probably because it was returning a QMap<QString,QString> which is not supported by DBus Adaptors.
Attached patch returns this functionality by using a QVariantMap instead.

Reproducible: Always

Steps to Reproduce:
Inspect KNotes dbus interface

Actual Results:  
No notes() method

Expected Results:  
notes() method returning a map of note id's to titles
Comment 1 Tejas Guruswamy 2010-09-21 12:26:30 UTC 
Created attachment 51852 [details]
Patch restoring notes() method to knotes
Comment 2 Allen Winter 2010-09-27 00:53:19 UTC 
SVN commit 1180082 by winterz:

restore notes() dbus interface
BUG: 251914
thanks for the patch Tejas.



 M  +2 -2      knotesapp.cpp  
 M  +1 -1      knotesapp.h  
 M  +4 -0      org.kde.KNotes.xml  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1180082
Comment 3 Allen Winter 2010-09-27 00:54:52 UTC 
SVN commit 1180083 by winterz:

merge forward SVN commit 1180082 by winterz:
restore notes() dbus interface
CCBUG: 251914
thanks for the patch Tejas.



 M  +2 -2      knotesapp.cpp  
 M  +1 -1      knotesapp.h  
 M  +4 -0      org.kde.KNotes.xml  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1180083
Comment 4 Allen Winter 2010-09-27 00:56:12 UTC 
SVN commit 1180084 by winterz:

merge forward SVN commit 1180082 by winterz:
restore notes() dbus interface
CCBUG: 251914
thanks for the patch Tejas. 




 M  +2 -2      knotesapp.cpp  
 M  +1 -1      knotesapp.h  
 M  +4 -0      org.kde.KNotes.xml  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1180084