Bug 251860 - [patch] Cancel button should change to close once photo upload is complete
Summary: [patch] Cancel button should change to close once photo upload is complete
Status: RESOLVED FIXED
Alias: None
Product: digikam
Classification: Applications
Component: Plugin-WebService-Facebook (show other bugs)
Version: unspecified
Platform: Ubuntu Linux
: NOR normal
Target Milestone: ---
Assignee: Digikam Developers
URL:
Keywords: junior-jobs
Depends on:
Blocks:
 
Reported: 2010-09-20 21:54 UTC by Mark Fraser
Modified: 2018-01-30 21:22 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In: 1.6.0


Attachments
Patch for fixing the bug. (5.40 KB, patch)
2010-11-01 01:13 UTC, Viranch Mehta
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Fraser 2010-09-20 21:54:10 UTC
Version:           1.4.0 (using KDE 4.5.1) 
OS:                Linux

If I upload some photos using the Facebook plugin, there are 2 buttons at the bottom of the window - "start upload" and "cancel". After the photos are uploaded both buttons still show "start upload" and "cancel" which makes it seem as if the upload hasn't completed.

Reproducible: Didn't try

Steps to Reproduce:
Select some photos and go Export >Facebook


Expected Results:  
Both the "start upload" and "cancel" buttons should disappear and be replaced by a "close" button.
Comment 1 Viranch Mehta 2010-11-01 01:13:12 UTC
Created attachment 53031 [details]
Patch for fixing the bug.
Comment 2 Viranch Mehta 2010-11-01 01:15:47 UTC
Comment on attachment 53031 [details]
Patch for fixing the bug.

New function createButtons() created. It re-creates the User1 button and helpMenu. The m_about definition moved to top in constructor. createButtons() is called:
1. inside constructor
2. in reactivate()
3. in slotStartTransfer() (for changing back to 'Cancel' from 'Close')
4. in uploadNextPhoto() (for changing 'Cancel' to 'Close')
Also, the 'start' button does not disappear after uploading to enable user to add more photos to list and upload them after he has uploaded previous photos.

SVN diff is attached.
Please let me know if anything is wrong since I started only recently to contribute.
Comment 3 Pau Garcia i Quiles 2010-11-10 18:30:24 UTC
Fixed in r1194777. Cancel renamed to Close.