Bug 251389 - Long running background actions and interactive actions should not conflict
Summary: Long running background actions and interactive actions should not conflict
Status: RESOLVED DUPLICATE of bug 284457
Alias: None
Product: krita
Classification: Applications
Component: Tools (show other bugs)
Version: unspecified
Platform: Unlisted Binaries Linux
: NOR normal
Target Milestone: ---
Assignee: Dmitry Kazakov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-09-16 00:39 UTC by Adam C
Modified: 2012-02-29 12:34 UTC (History)
5 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:

Attachments
Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Adam C 2010-09-16 00:39:13 UTC 
Version:           unspecified
OS:                Linux

the new transform tool does it's work in the background, so that the userinterface is not blocked.

this can cause various crashes:
o if clicking on apply button a second time
o if changing to the brush tool and draw
o if scaling the layer or image by the function in the menu
o if deleting the current layer

Reproducible: Always
Comment 1 Dmitry Kazakov 2010-09-16 12:50:19 UTC 
I think it is partly connected with https://bugs.kde.org/show_bug.cgi?id=248374.
At least first three crashes.
Comment 2 Sven Langkamp 2010-09-18 15:16:38 UTC 
SVN commit 1176731 by langkamp:

also check for systemLocked
BUG:251389


 M  +1 -1      kis_tool_transform.cc  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1176731
Comment 3 Adam C 2010-09-19 11:09:40 UTC 
reopening, as it is still possible to crash krita by using the menu or deleting the layer.
Comment 4 Sven Langkamp 2010-09-19 18:46:02 UTC 
SVN commit 1177167 by langkamp:

don't remove node while working on them
BUG:251389


 M  +2 -0      kis_layer_box.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1177167
Comment 5 Marc Pegon 2010-09-19 22:37:08 UTC 
SVN commit 1177239 by pegon:

Fixed crash on removing layer while in transform tool.
BUG:251389



 M  +20 -2     kis_tool_transform.cc  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1177239
Comment 6 Marc Pegon 2010-09-19 22:42:13 UTC 
Closed the wrong bug.. Let's reopen this one.
Comment 7 Marc Pegon 2010-09-24 22:48:58 UTC 
I tried those :
o if changing to the brush tool and draw
o if scaling the layer or image by the function in the menu
o if deleting the current layer

It doesn't crash anymore. Can someone else confirm ?
Comment 8 Sven Langkamp 2010-09-24 23:07:05 UTC 
The crashing itself is fixed, by the lock. We are currently discussing on the mailinglist how this can be solve in a better way.
Comment 9 Halla Rempt 2010-10-09 11:41:54 UTC 
See the discussion on the mailing list: http://lists.kde.org/?l=kde-kimageshop&m=128505006220448&w=2
Comment 10 Cyrille Berger 2010-11-05 10:40:55 UTC 
Is the bug solved for 2.3 ? (even if a better solution is needed for later) In which case, could we remove the release_blocker tag ?
Comment 11 Halla Rempt 2010-11-05 10:55:59 UTC 
Yes, the tag can be removed since we also demoted this bug from major to normal.
Comment 12 Halla Rempt 2011-10-16 13:49:35 UTC 
This now awaits porting all tools/actions to the strokes framework, afaik
Comment 13 Dmitry Kazakov 2011-12-17 08:47:07 UTC 
This bug affects Backspace shortcut as well. Can be seen really well on 16bit images
Comment 14 Halla Rempt 2012-02-29 12:34:15 UTC 
Make it a duplicate of 284457 "Remaining tools need to be ported to the strokes framework "

*** This bug has been marked as a duplicate of bug 284457 ***