Bug 251199 - [PATCH] Stop fetching/updating context widget's content from internet when amarok's window is not visible
Summary: [PATCH] Stop fetching/updating context widget's content from internet when am...
Status: CONFIRMED
Alias: None
Product: amarok
Classification: Applications
Component: Context View (show other bugs)
Version: 2.4.1
Platform: Ubuntu Linux
: NOR wishlist
Target Milestone: 2.4.0
Assignee: Amarok Developers
URL: https://git.reviewboard.kde.org/r/119...
Keywords:
Depends on: 229111
Blocks:
  Show dependency treegraph
 
Reported: 2010-09-14 11:56 UTC by Sylvain Paré
Modified: 2014-09-14 19:03 UTC (History)
4 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
Patch for Wikipedia and Lyrics context applets (11.54 KB, patch)
2014-08-19 18:13 UTC, H L Prasad
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Sylvain Paré 2010-09-14 11:56:59 UTC
Version:           2.3.1 (using KDE 4.5.1) 
OS:                Linux

For me it is not a wish but really a bug.
Here currently a have a poor internet connection.
And some time I play to FPS game ( Nexuiiiiiz :) ) and I like to play with some background music. And that hurts here.
While playing quite well despite my poor connection, thanks nexuiz code, at each time amarok changes to a new track It is like I lost my connection during at least 5". And this is dues to all the context widgets I have which are fetching their content from internet. But hey! what for!? I don't even have amarok window on!
So for me fetching/updating context widget's content from internet when amarok's window is not visible is really not the best way to do.
I thinks when amarok is minimized it should not fetch any context content and fetch it as soon as amarok is maximized.
Thank you!
Best regards

Reproducible: Always

Steps to Reproduce:
at each next track
Comment 1 Myriam Schweingruber 2010-09-14 12:42:06 UTC
Why don't you disable the Context View pane all together? See the Views menu -> unlock layout. Then you can just disable it, that should solve the problem, no?
Comment 2 Sylvain Paré 2010-09-14 13:32:29 UTC
Why should I have to do any thing ?
Amarok rocks or not ? :)
It is painful to have to disable something and then re-enable it back after..
Plus... no it does not even solve it! not context view enabled but it does still fetched content.. a real bug!
I will look at the code to see if I am able to do something


NB: long live to Xonotic, the open source fork of Nexuiz
Comment 3 Myriam Schweingruber 2010-09-14 15:17:53 UTC
You don't understand: if you enable applets that fetch content from the internet, then it will happen, regardless if the Amarok window is visible or not. If you don't want it to fetch content, then just disable the Context View or don't load the applets that do fetch content from the net. Either you use the internet or not, your choice.
Since you don't want it to use the internet you don't need to have these applets enabled anyway.
Comment 4 Sylvain Paré 2010-09-14 15:43:54 UTC
Excuse me Myriam with all the respect I have to you I totally disagree with you.
Amarok is a music player and tell me if I am wrong but It is not mean to be used only in a Amarok's windows on mode(maximized). So I will not remove context widget each time i will minimized Amarok!(It is completely stupid. at least is way more stupid to do this rather than to disable content fetching in minimized mode) Like I will not removing my WiFi's configuration just because I am changing of AP; no the software permit a better usage.
And sorry but saying to a user that he does not understand is not relevant here as I do understand what it is going. I am just saying that in my opinion it should not work like this because we can do much better.
Comment 5 Myriam Schweingruber 2010-12-14 00:19:41 UTC
Setting status correctly. AFAIK this is still valid for 2.3.2 as well.
Comment 6 Myriam Schweingruber 2011-06-04 12:10:36 UTC
This is an automated message from the triager:

Amarok 2.4.1 has been released on May 8 already. Could you please upgrade and test if you can still reproduce this bug?

Without feedback within a month we will close this bug as resolved.

Thank you for your understanding.
Comment 7 Sylvain Paré 2011-06-04 16:08:01 UTC
I separate this bug to point the real bug here
https://bugs.kde.org/show_bug.cgi?id=274919
then it remains that this could be a goos feature to implement: don't fetching if amarok is minimized.
Comment 8 Sylvain Paré 2011-06-04 16:08:45 UTC
sorry forgot to change statu
Comment 9 Myriam Schweingruber 2011-06-04 18:03:27 UTC
Thank you for the fast feedback :)
Comment 10 Kevin Funk 2011-06-05 13:04:51 UTC
It's an enhancement after all, marking this as wish. Not sure if this ever going to be implemented since it requires some work in the context applet architecture.
Comment 11 Sylvain Paré 2011-06-07 21:45:05 UTC
agreed this is a wish! :)
thx cu
Comment 12 H L Prasad 2014-08-11 14:48:49 UTC
This issue is still there in 2.8.0. When is this expected to be implemented?
Comment 13 Myriam Schweingruber 2014-08-11 14:56:55 UTC
(In reply to H L Prasad from comment #12)
> This issue is still there in 2.8.0. When is this expected to be implemented?

Care to give a hand?
Comment 14 H L Prasad 2014-08-11 15:32:43 UTC
Yes, I would be interested in helping to the extent I can. I am new to KDE SDK, Amarok codebase. But, I am proficient in C++ and know Qt reasonably. I use Kdevelop extensively in my work. 

Kindly suggest a way to start.

I am using Ubuntu 14.04 with KDE 4.13.2.
Comment 15 H L Prasad 2014-08-11 15:35:06 UTC
Never mind. Got https://community.kde.org/Amarok/Development. 

If anything specific which will be useful in connection with this bug, please suggest.
Comment 16 Myriam Schweingruber 2014-08-11 15:48:21 UTC
Well, it is not a bug, it is a feature request, so you might check on the amarok-devel@kde.org mailing list for more information before starting to work on it.
Comment 17 Alan Ezust 2014-08-12 21:11:06 UTC
Personally, I think that if the Context Widget is not visible, it should also disable the context widgetss fetching behaviors. Not just when Amarok is hidden, but also when the context widget is hidden or closed.

And since there are context widgets enabled by default, this is a bug, not just a feature request. If you had to enable each context widget yourself, then I would see it as a feature request but since you have to disable them after each amarok install, this is a bug.
Comment 18 Myriam Schweingruber 2014-08-12 23:12:35 UTC
A non implemented feature is not a bug, it is a feature that needs to be implemented. It would be a bug if the feature is implemented and doesn't work.
Comment 19 H L Prasad 2014-08-19 18:13:20 UTC
Created attachment 88324 [details]
Patch for Wikipedia and Lyrics context applets
Comment 20 H L Prasad 2014-08-19 18:14:41 UTC
Could somebody please try the patch sent in the previous comment and check its usability?
Comment 21 Myriam Schweingruber 2014-08-19 21:31:08 UTC
Please submit your patch to http://reviewboard.kde.org for the group Amarok. You will need an account on ghttp://identity.kde.org for that. Then please provide the link to reviewboard here.
Comment 22 H L Prasad 2014-08-20 03:33:41 UTC
Already done.
Comment 23 H L Prasad 2014-08-20 03:46:25 UTC
Please see https://git.reviewboard.kde.org/r/119848/
Comment 24 H L Prasad 2014-09-14 14:31:40 UTC
@Myriam: Any chance of this going to mainstream soon?
Comment 25 Myriam Schweingruber 2014-09-14 19:03:07 UTC
(In reply to H L Prasad from comment #24)
> @Myriam: Any chance of this going to mainstream soon?

I am not responsible for code review nor for releases, sorry. Just be patient.