Bug 251164 - Copy shortcut does not work
Summary: Copy shortcut does not work
Status: CONFIRMED
Alias: None
Product: choqok
Classification: Applications
Component: general (show other bugs)
Version: 1.3
Platform: Ubuntu Linux
: NOR wishlist
Target Milestone: ---
Assignee: Mehrdad Momeny
URL:
Keywords: junior-jobs
: 256117 (view as bug list)
Depends on:
Blocks:
 
Reported: 2010-09-14 00:14 UTC by chx1975
Modified: 2018-06-05 23:18 UTC (History)
5 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments
Patch the bug by adding Copy and Select-All Shortcuts (1.95 KB, patch)
2018-03-17 21:20 UTC, Braxton Salyer
Details
Patch the bug by adding Copy and Select-All Shortcuts (1.95 KB, patch)
2018-03-17 21:22 UTC, Braxton Salyer
Details

Note You need to log in before you can comment on or make changes to this bug.
Description chx1975 2010-09-14 00:14:12 UTC
Version:           0.9.85 (1.0 Beta2) (using KDE 4.5.1) 
OS:                Linux

Ctrl+C does not work in this version. I select something, press Ctrl+C the contents do not get to the clipboard, right-click copy works.

Reproducible: Always
Comment 1 Mehrdad Momeny 2010-11-05 09:36:11 UTC
*** Bug 256117 has been marked as a duplicate of this bug. ***
Comment 2 Sven Lankes 2011-01-30 14:28:36 UTC
Still valid for Version 1.0.

Marked text does show up in klipper after CTRL-C but it's not available for paste using CTRL-V.
Comment 3 Anders Lund 2011-01-30 14:48:21 UTC
@Sven: If you configure clipper to syncronize the clipboard and the selection, you can paste mouse selected text from most widgets. 

Copy is still not working in 1.0, I can comfirm that.
Comment 4 Kevin Kofler 2011-01-30 18:12:17 UTC
The text shows up in Klipper because Klipper also picks up selections ready for middle-click paste (PRIMARY in X11 jargon), not just stuff actually copied into the clipboard (CLIPBOARD in X11 jargon).
Comment 5 Adrián Chaves (Gallaecio) 2012-10-02 06:39:39 UTC
I can confirm this in Choqok 1.3 too.

I also think this is actually a wish, not a bug. It is not that Choqok tells you to use Ctrl+C to copy and it doesn’t work, it’s just that Choqok does not provide a shortcut to copy. Same happens with Ctrl+A to Select All.
Comment 6 Braxton Salyer 2018-03-17 03:07:57 UTC
I think this may currently be a design decision from the choqok team until the app gets ported to kirigami, as it clearly used to rely on kde4libs and simply has the relevant code commented out.

That said, for some reason, this segfaults for me when I build from source BEFORE I make any changes, but I have come up with a possible? fix for this particular thing if someone else wants to try it out:

in cmakelists.txt insert at line 60

KF5::ConfigGui

in /libchoqok/ui/textbrowser.cpp insert at line 37

#include <KStandardShortcut>

replace line 122 w/

copy->setShortcut( KStandardShortcut::copy().at(0) );

replace line 133 w/

selectAll->setShortcut( KStandardShortcut::selectAll().at(0) );
Comment 7 Anders Lund 2018-03-17 08:26:29 UTC
I believe kirigami was not even thought of at the time of reporting - but nice 
if a port can solve this ;)

Anders
Comment 8 Braxton Salyer 2018-03-17 20:16:24 UTC
(In reply to Anders Lund from comment #7)
> I believe kirigami was not even thought of at the time of reporting - but
> nice 
> if a port can solve this ;)
> 
> Anders

ahh that's true. I might not have looked at the dates when I posted my reply haha
Comment 9 Braxton Salyer 2018-03-17 21:20:42 UTC
Created attachment 111468 [details]
Patch the bug by adding Copy and Select-All Shortcuts

Got Choqok working from source. turns out it was a (sort of) environment issue.


Anyways the possible patch a mentioned before works.
This patch adds Copy and Select-All Shortcuts to Choqok.

I'm also going to submit this on phabricator
Comment 10 Braxton Salyer 2018-03-17 21:22:28 UTC
Created attachment 111469 [details]
Patch the bug by adding Copy and Select-All Shortcuts

Sorry, forgot to click the "Patch" checkbox the first time ;)
Comment 11 Christoph Feck 2018-03-30 13:54:58 UTC
Is there a reason why you only set the first shortcut? There is also a QAction::setShortcuts() method that accepts the complete list.
Comment 12 Christoph Feck 2018-04-26 21:45:21 UTC
If you have an updated patch, please add here or to https://phabricator.kde.org/differential/diff/create/
Comment 13 Christoph Feck 2018-05-16 16:22:56 UTC
Braxton, any update?
Comment 14 Christoph Feck 2018-06-05 23:18:20 UTC
Assignee not responding.