Bug 250642 - BQM Watermark tool : signature does not respect correct orientation
Summary: BQM Watermark tool : signature does not respect correct orientation
Status: RESOLVED FIXED
Alias: None
Product: digikam
Classification: Applications
Component: Plugin-Bqm-WaterMark (show other bugs)
Version: 1.2.0
Platform: Ubuntu Linux
: NOR normal
Target Milestone: ---
Assignee: Digikam Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-09-09 11:20 UTC by Axel Krebs
Modified: 2017-02-09 21:32 UTC (History)
4 users (show)

See Also:
Latest Commit:
Version Fixed In: 5.5.0
Sentry Crash Report:


Attachments
signature at wrong posistion + wrong orientation (456.45 KB, image/jpeg)
2010-09-09 11:26 UTC, Axel Krebs
Details
"orientation" - mixture between "position" and "orientation"? (274.11 KB, image/jpeg)
2011-04-20 16:40 UTC, Axel Krebs
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Axel Krebs 2010-09-09 11:20:15 UTC
Version:           1.2.0 (using KDE 4.4.2) 
OS:                Linux

When making signature in a batch-procedure, the landscape orientation shows signature as desired "right bottom".

Upright pics shows signature "righht-above".

As the orientation is respected correctly, the signature should show up "right-bottem" 

Reproducible: Always

Steps to Reproduce:
Pic selection
batch
signature
choose details as font, colour, size + placement
run batch

Actual Results:  
signature appears at wrong place and at wrong location- who turns ones head to watch a pic, just to read the signature?

Expected Results:  
signature should always appear at the originally _choosen_ place, here (in upright pics) again in the originally choosen position right-bottom.

Please compare to sample

OS: Linux (x86_64) release 2.6.32-24-generic
Compiler: cc
Comment 1 Axel Krebs 2010-09-09 11:26:12 UTC
Created attachment 51457 [details]
signature at wrong posistion + wrong orientation
Comment 2 caulier.gilles 2010-10-05 13:59:18 UTC
Axel, 

i can reproduce the problem, but it versy simple to solve it.

As you can chain Batch tools in queue manager, just apply rotate tool previously using Exif orientation flag, and all will be fine.

Gilles Caulier
Comment 3 Axel Krebs 2010-10-05 18:12:55 UTC
Gilles:

I am happy that you care for this question.

I can not really agree to you, however; in ergonomics, there is a _basic_ rule to be followed for users expectation reasons: 

>> I get, what I want<<

Rem.: in German "Erwartungstreue" (sorry, don`t find english translation)

In concrete: if I want a signature somewhere (whereever!!!), I expect it to get _there_. No tricks, no additional tricks. Just this!
Comment 4 Stefano 2010-10-12 09:12:42 UTC
Gilles,

I second this bug, it is pretty annoying indeed ;)

Also, it does not remember the settings (don't know if it is a general bug though), as of 1.4.0.
Comment 5 Axel Krebs 2011-04-20 16:40:31 UTC
Created attachment 59159 [details]
"orientation" - mixture between "position" and "orientation"?

In "batch manager", "add watermark", we can easily choose a "position". 

In mathematics, they distinguish between "position" (left up) and "orientation" "landscape" _or_ "upright", this is 4 x 4 = 16 possibilities!

Maybe a simple solution could be to pre-assume the oriention in "album view"(?) or "thumbnail view"(?) as a reference for watermarks (position _and- orientation).
Comment 6 Axel Krebs 2012-09-15 11:59:24 UTC
please compare to bug290416, meaning appearently a similar bug!!
Comment 7 J Appel 2012-09-15 14:55:17 UTC
*** Bug 290416 has been marked as a duplicate of this bug. ***
Comment 8 J Appel 2012-09-15 14:57:51 UTC
 bug290416 is similar. I tried to rotate images first and then apply the watermark - which didnt lead to the expected result.
Comment 9 Ahmed Fathi 2017-02-08 21:58:22 UTC
I think this patch solves this problem : 
https://bugs.kde.org/show_bug.cgi?id=338869
Comment 10 caulier.gilles 2017-02-09 21:32:26 UTC
Git commit d54da04770450fa56a712d05485b73f023b008c2 by Gilles Caulier.
Committed on 09/02/2017 at 21:24.
Pushed by cgilles into branch 'master'.

apply patch #103909 to add rotation feature in BQM watermark tool with exif orientation support.
Related: bug 338869, bug 290944
FIXED-IN: 5.5.0

M  +6    -1    NEWS
M  +50   -0    libs/dimg/dimg.cpp
M  +6    -1    libs/dimg/dimg.h
M  +6    -0    libs/threadimageio/loadsavethread.cpp
M  +5    -0    libs/threadimageio/loadsavethread.h
M  +83   -12   utilities/queuemanager/tools/decorate/watermark.cpp
M  +1    -1    utilities/queuemanager/tools/decorate/watermark.h

https://commits.kde.org/digikam/d54da04770450fa56a712d05485b73f023b008c2