Bug 249152 - Get new hot stuff require gpg (gnupg), but doesn't have the dependency (should try gnupg2 first)
Summary: Get new hot stuff require gpg (gnupg), but doesn't have the dependency (shoul...
Status: RESOLVED FIXED
Alias: None
Product: kdelibs
Classification: Unmaintained
Component: knewstuff (show other bugs)
Version: 4.5
Platform: Fedora RPMs Linux
: NOR normal
Target Milestone: ---
Assignee: Jeremy Whiting
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-08-26 23:00 UTC by MartinG
Modified: 2024-05-10 21:57 UTC (History)
4 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description MartinG 2010-08-26 23:00:33 UTC
Version:           4.5
OS:                Linux

When trying to install new plasmoid to the panel, using Get New Hot stuff, installation failed for me, as I didn't have gnupg (gpg) installed, I only had gnupg2 (gpg2) installed. The thingy couldn't retrieve the authentication keys or something. 

(After installing gnupg in addition to gnupg2, everything worked, also after uninstalling gnupg, as I guess the keys are stored)

Reproducible: Didn't try

Steps to Reproduce:
Try to install new stuff using Get new hot stuff, without having gnupg installed, and without already having the keys cached.

Actual Results:  
It fails if gnupg is not installed.

Expected Results:  
Either add dependency to gnupg (v1) or add support for gnupg2
Comment 1 Rex Dieter 2010-08-26 23:03:34 UTC
confirmed, though this is more about adding support for gpg2 (rfe).

In my quick-n-dirty inspection of gpg command-line usage, it would appear that gpg2 should be able to work here too, any objections to adding support for it?

(yes, I'm volunteering to help write the code). :)
Comment 2 Frederik Gladhorn 2010-08-28 02:15:48 UTC
Hi, where does this appear? I'm a bit out of the loop and surprised this happens with kde 4.5 where anything related to signatures should not be implemented in knewstuff. Could it be that this is inside Plasma only? I do want it to be in knewstuff, but this still surprises me ...
Comment 3 MartinG 2010-08-28 14:17:29 UTC
KDE 4: from the panel, right click, unlock widgets, click the thingy to the right, then Add Widgets..., then "Get New Widgets...", Download New Plasma Widgets. A window with title "Get New Hot Stuff - Plasma Workspace" appears.
Click Install on one of them -> fail (if the key is not already in place, and gnupg (v1) is not installed).

:)
Comment 4 MartinG 2010-08-28 14:18:40 UTC
This is for 
kdelibs-4.5.0-5.fc15.x86_64
kdeplasma-addons-4.5.0-1.fc15.x86_64
kdeplasma-addons-libs-4.5.0-1.fc15.x86_64
Comment 5 Diego Casella 2010-08-28 15:41:01 UTC
(In reply to comment #3)
> KDE 4: from the panel, right click, unlock widgets, click the thingy to the
> right, then Add Widgets..., then "Get New Widgets...", Download New Plasma
> Widgets. A window with title "Get New Hot Stuff - Plasma Workspace" appears.
> Click Install on one of them -> fail (if the key is not already in place, and
> gnupg (v1) is not installed).
> 
> :)

I'm surprised as Frederik about this bug, since I didn't committed anything about gpg signature/fingerprint handling yet (due to my lack of time in these last weeks, my bad)... It should simply parse the content, create the attributes for those gpg fields and then do nothing with them, since there are no API calls to handle them.
By the way, which key are you talking about?

The gpg executable issue is even more strange, since neither kdelibs, nor kdebase requires it for building; the only relationship that came in my mind between plasma and gpg is that plasma requires QCA to enable the remote widgets functionality, which needs a specific QCA plugin, called qca-gnupg, to do its crypto stuff. This plugin relies on the gpg executable and, if it is not present, guess what happens?
Still, I can't figure out how it could be related to our problem. Other ideas?
Comment 6 Rex Dieter 2010-08-28 20:04:24 UTC
Re comment #2  'where does this appear?'

In kdelibs,
knewstuff2/core/security.cpp
knewstuff3/core/security.cpp

several references to calling 'gpg' binary.
Comment 7 Christoph Cullmann 2024-05-10 21:57:16 UTC
I think this works with recent versions.