Bug 248684 - convolution on a single channel doesn't work.
Summary: convolution on a single channel doesn't work.
Status: RESOLVED FIXED
Alias: None
Product: krita
Classification: Applications
Component: General (show other bugs)
Version: unspecified
Platform: Unlisted Binaries Linux
: NOR normal
Target Milestone: ---
Assignee: Dmitry Kazakov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-08-22 11:22 UTC by Halla Rempt
Modified: 2011-07-19 13:04 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:

Attachments
Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Halla Rempt 2010-08-22 11:22:29 UTC 
We used to be able to convolve on a subset of the channels of a paint device. This no longer is possible, but it is important for some effects and techniques.

To test, re-enable the testMaskConvolutionOnRedChannel test in KisConvolutionPainterTest.
Comment 1 Dmitry Kazakov 2010-10-26 21:49:30 UTC 
Should it go to 2.3? I can take it, i guess
Comment 2 Dmitry Kazakov 2010-11-14 11:55:36 UTC 
Well, the test is fixed how can i check this in the UI?
Comment 3 Cyrille Berger 2010-11-14 15:09:03 UTC 
right-click on a layer (in layer box), disable some channels, then filter.
Comment 4 Halla Rempt 2011-07-19 12:38:24 UTC 
Despite fixing a lot of channel issues, this seems to be still broken. The unittest works file; maybe the channelflags aren't set in the filter config?
Comment 5 Halla Rempt 2011-07-19 12:55:51 UTC 
Looks like it... Working on it now.
Comment 6 Halla Rempt 2011-07-19 13:04:20 UTC 
Git commit 0d400ab3ee0e040fd9ec47a068bca0f6c27edfb5 by Boudewijn Rempt.
Committed on 19/07/2011 at 15:03.
Pushed by rempt into branch 'master'.

Pass the layer's channel bitset on to the filter

BUG:248684

Todo: make the filter layers and masks respect the selected channels
properly

M  +3    -0    krita/ui/dialogs/kis_dlg_filter.cpp

http://commits.kde.org/calligra/0d400ab3ee0e040fd9ec47a068bca0f6c27edfb5