Bug 247835 - hairy brush paints predefined brushes four times and with weird colors
Summary: hairy brush paints predefined brushes four times and with weird colors
Alias: None
Product: krita
Classification: Applications
Component: Brush engines (show other bugs)
Version: git master (please specify the git hash!)
Platform: Unlisted Binaries Linux
: NOR normal
Target Milestone: ---
Assignee: LukasT
Depends on:
Reported: 2010-08-14 10:52 UTC by Halla Rempt
Modified: 2010-09-08 18:01 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:

settings (183.56 KB, image/png)
2010-08-14 10:52 UTC, Halla Rempt

Note You need to log in before you can comment on or make changes to this bug.
Description Halla Rempt 2010-08-14 10:52:27 UTC
Created attachment 50528 [details]

When painting with the hairy brush, if you select one of the predefined brush tips you get very interesting results: it seems as if the tip is deformed, painted four times and with lots of color variation. See attachment
Comment 1 LukasT 2010-08-24 10:21:28 UTC

The problem is that KisBrush provides image() and hairy brush uses directly that image. It is called preview but it is not preview for e.g. gbr brushes where it is used as base for the mip-mapping levels. It is not scaled and also the pixel format might be different that the code expects.

It will be fixed by rendering the status of the brush into paint device and then the shape of the hairy brush will be taken from the rendered image.
Comment 2 LukasT 2010-09-08 18:01:11 UTC
SVN commit 1173087 by lukast:

Fix painting with predefinded brushes.
Speedup in range 1.15 - 1.30, tested with benchmarks.

o Now it renders the dab and takes the bristles
  from it instead of using preview image.
o use const reference to avoid copying the QVector


 M  +0 -1      CMakeLists.txt  
 D             brush_shape.cpp  
 D             brush_shape.h  
 M  +40 -23    hairy_brush.cpp  
 M  +5 -7      hairy_brush.h  
 M  +17 -44    kis_hairy_paintop.cpp  
 M  +1 -3      kis_hairy_paintop.h  
 M  +1 -1      trajectory.cpp  
 M  +2 -2      trajectory.h  

WebSVN link: http://websvn.kde.org/?view=rev&revision=1173087