Bug 245606 - Dragging picture to desktop sometimes sets slideshow for background
Summary: Dragging picture to desktop sometimes sets slideshow for background
Status: RESOLVED FIXED
Alias: None
Product: plasma4
Classification: Unmaintained
Component: containment-desktop (show other bugs)
Version: unspecified
Platform: openSUSE Linux
: NOR minor
Target Milestone: ---
Assignee: Plasma Bugs List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-07-24 04:12 UTC by greg.freemyer
Modified: 2010-08-09 16:31 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description greg.freemyer 2010-07-24 04:12:18 UTC
Version:           unspecified (using KDE 4.4.4) 
OS:                Linux

If you have the background set to globe at night as an example, then drag a jpg onto the background, the background should change to the one static picture.

Instead it sets the mode to snapshot mode.

Seems to be true with several other starting conditions, but not if you're already in single picture background mode.


Reproducible: Always
Comment 1 Will Stephenson 2010-07-26 16:40:15 UTC
Confirmed
Comment 2 Will Stephenson 2010-07-29 14:07:33 UTC
Nailed it: when a file is dropped on the desktop, its mimetype is evaluated to see what widgets or wallpaper plugins can be activated to handle it.  When it is a wallpaper, the plugin expects two arguments: the URL to display (of the file) and the rendering mode to use.  The rendering mode is an empty string, which according to the API means use the default mode.  However in the implementation of the Image wallpaper plugin, which has two modes, Single Image and Slideshow, all the logic is based on a positive test for Single Image - any other value (eg an empty string) falls back to SlideShow.  I have added a test patch to the openSUSE kdebase4-workspace KDE:Distro:Stable packages that treats an empty string in the Image wallpaper as Single Image, but I am going to pursue a proper fix in the Wallpaper plugin base class on plasma-devel@.
Comment 3 Will Stephenson 2010-08-09 16:31:38 UTC
Fixed the easy way after consultation with Plasma-devel@