Bug 245061 - [patch] "Restore Tag Filters" is broken, works only for top level nodes
Summary: [patch] "Restore Tag Filters" is broken, works only for top level nodes
Status: RESOLVED FIXED
Alias: None
Product: digikam
Classification: Applications
Component: Albums-Filters (show other bugs)
Version: 1.4.0
Platform: Compiled Sources Linux
: NOR minor
Target Milestone: ---
Assignee: Digikam Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-07-18 18:32 UTC by Bastiaan Hovestreydt
Modified: 2012-06-27 10:46 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In: 1.4.0
Sentry Crash Report:

Attachments
Patch to repair "Restore Tag Filters" feature (415 bytes, patch)
2010-07-18 18:32 UTC, Bastiaan Hovestreydt 		Details
View All Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Bastiaan Hovestreydt 2010-07-18 18:32:48 UTC 
Created attachment 49293 [details]
Patch to repair "Restore Tag Filters" feature

Version:           1.4.0 (using Devel) 
OS:                Linux

There seems to be missing a line of code to recurse the children of the tag tree in AbstractCheckableAlbumTreeView::restoreCheckStateForHierarchy.
I've attached a patch to fix this.

Reproducible: Always

Steps to Reproduce:
Set "Restore Tag Filters" to "On" in tag filter sidebar
Check some tags in the tag filter, which are not on the top level
Close Digikam
Start Digikam
Observe, that checked tags were not restored
Comment 1 Johannes Wienke 2010-07-18 20:26:27 UTC 
SVN commit 1151296 by jwienke:

Fix restoring the check-state of tree views also for children.

Thanks for the patch.

BUG: 245061

 M  +2 -1      NEWS  
 M  +1 -0      digikam/albumtreeview.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1151296