Bug 244908 - 'Automatic spell checking enabled' always
Summary: 'Automatic spell checking enabled' always
Status: VERIFIED FIXED
Alias: None
Product: kmail2
Classification: Applications
Component: composer (show other bugs)
Version: unspecified
Platform: Compiled Sources Linux
: NOR normal
Target Milestone: ---
Assignee: kdepim bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-07-16 23:29 UTC by Sabine Faure
Modified: 2010-07-22 23:51 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Sabine Faure 2010-07-16 23:29:09 UTC
Version:           unspecified (using Devel) 
OS:                Linux

The spellchecker is always automatically activated whether the 'Automatic spell checking enabled by default' check box is checked or not.

Reproducible: Always

Steps to Reproduce:
- Launch Kontact and go to Kmail
- Click on 'New Message'
- Go to Settings menu/Spellchecker...
- Make sure that the 'Automatic spell checking enabled by default' check box is not checked
- Type a few words in the text editor including spelling mistakes (ex: My sister is travelling to Edimbourg by plane)

Actual Results:  
'Travelling' and 'Edimbourg' are both underlined automatically by the spellchecker

Expected Results:  
whereas they should not be since the automatic spellchecker is unchecked.

Trunk, Svn Rev 1150720
Comment 1 Laurent Montel 2010-07-19 10:59:12 UTC
Ok I can reproduce it.
Will look at it
Comment 2 Laurent Montel 2010-07-19 17:49:31 UTC
SVN commit 1151810 by mlaurent:

Fix  Bug 244908 -  'Automatic spell checking enabled' always"
CCBUG: 244908


 M  +6 -0      highlighter.cpp  
 M  +6 -0      highlighter.h  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1151810
Comment 3 Laurent Montel 2010-07-19 17:51:36 UTC
SVN commit 1151813 by mlaurent:

Fix bug #244908
BUG: 244908


 M  +1 -1      emailquotehighlighter.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1151813
Comment 4 Sabine Faure 2010-07-22 23:37:04 UTC
I retested this today and the spellchecker is still always enabled whether the check box is checked or not so I am reopening this bug.

Trunk, Svn Rev 1153123
Comment 5 Sabine Faure 2010-07-22 23:38:21 UTC
I retested this using kdelibs 4.5 in case you are wandering.

Trunk, Svn Rev 1153123
Comment 6 David Faure 2010-07-22 23:43:02 UTC
SVN commit 1153250 by dfaure:

make this work even with the current version of kdelibs-4.5
CCBUG: 244908


 M  +1 -1      emailquotehighlighter.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1153250
Comment 7 Sabine Faure 2010-07-22 23:51:16 UTC
It is corrected now.

The Spellchecker is only enabled is the 'Automatic spell checking enabled by default' check box is checked now.

Trunk, Svn Rev 1153240