Bug 242192 - kompare could not open a temporary file when saving difference
Summary: kompare could not open a temporary file when saving difference
Status: RESOLVED FIXED
Alias: None
Product: kompare
Classification: Applications
Component: general (show other bugs)
Version: 4.0.0
Platform: Ubuntu Linux
: NOR normal
Target Milestone: ---
Assignee: Kompare developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-06-19 19:54 UTC by Mark Fraser
Modified: 2010-07-08 06:09 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
patch 'could not open a temporary file' (630 bytes, patch)
2010-07-01 19:28 UTC, mangus
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Fraser 2010-06-19 19:54:30 UTC
Version:           4.0.0 (using Devel) 
OS:                Linux

Applied a difference tried to save the new file, but I got the error could not open a temporary file.

Reproducible: Didn't try

Steps to Reproduce:
Load 2 files, click on apply difference button, click on save.

Actual Results:  
Error box appeared.

Expected Results:  
I expected the difference to be saved to the file.

OS: Linux (i686) release 2.6.32-22-generic
Compiler: cc
Comment 1 Mark Fraser 2010-06-19 19:55:16 UTC
This is with KDE 4.4.85
Comment 2 mangus 2010-06-21 22:13:31 UTC
Same here. Reproducible. KDE 4.4.85
Comment 3 Danni Coy 2010-06-30 09:49:31 UTC
confirmed for KDE 4.4.90 on Kubuntu lucid
Comment 4 mangus 2010-07-01 19:28:05 UTC
Created attachment 48522 [details]
patch 'could not open a temporary file'

I managed to solve this. The patch solves this issue for me and also the same error happening when we try to save a diff from the menu.
please review the patch since I'm not a c++ professional..
:-)
thanks

patch created with kompare, doh!
Comment 5 Kevin Kofler 2010-07-02 15:48:36 UTC
SVN commit 1145313 by kkofler:

Fix inverted logic introduced by revision 1091068 (apol's Qt3Support removal in libdiff2).
Patch by mangus (from bugs.kde.org attachment).
BUG: 242192
CCMAIL: aleixpol@kde.org

 M  +2 -4      komparemodellist.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1145313
Comment 6 Kevin Kofler 2010-07-07 05:52:50 UTC
Darn, 4.5 is already branched, why did nobody tell me? I'll backport the fix to 4.5 as well. (4.4 and earlier are not affected, the bug is a regression in the trunk after 4.4 branched.)
Comment 7 Kevin Kofler 2010-07-08 06:09:31 UTC
SVN commit 1147381 by kkofler:

Fix inverted logic introduced by revision 1091068 (apol's Qt3Support removal in libdiff2).
Patch by mangus (from bugs.kde.org attachment).
CCBUG: 242192
CCMAIL: aleixpol@kde.org
(backport revision 1145313 from trunk)

 M  +2 -4      komparemodellist.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1147381