Bug 240771 - Ratings/tags do not save when changed via the current track plasmoid
Summary: Ratings/tags do not save when changed via the current track plasmoid
Status: RESOLVED WORKSFORME
Alias: None
Product: amarok
Classification: Applications
Component: Context View/Current Track (show other bugs)
Version: 2.4-GIT
Platform: Ubuntu Linux
: HI normal
Target Milestone: 2.4.0
Assignee: Amarok Developers
URL:
Keywords:
: 251908 (view as bug list)
Depends on:
Blocks:
 
Reported: 2010-06-04 23:55 UTC by ian.merrithew
Modified: 2010-12-13 18:10 UTC (History)
6 users (show)

See Also:
Latest Commit:
Version Fixed In: 2.4


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description ian.merrithew 2010-06-04 23:55:01 UTC
Version:           2.3.0 (using KDE 4.4.2) 
OS:                Linux

If I edit a song's tag or rating from either the playlist or from the Context View applet, the changes are not saved when using an external MySQL database for the collection.

Such changes are saved when using the internal database.

Reproducible: Always

Steps to Reproduce:
No special steps required to reproduce. Simply edit a rating from the Context View for example. The stars will change. 

Actual Results:  
Observe that the rating shown in the playlist does not change. Right click on the track and display the track details; observe that the rating has not in fact changed. Open the MySQL database and observe that the rating as stored in the "statistics" table for the track has not changed.

Expected Results:  
The rating should change in the playlist and should change in the track details; meaning, the rating should be saved to the MySQL database.
Comment 1 Myriam Schweingruber 2010-06-05 02:03:25 UTC
Please check your permissions for the external MySQL, this should not work differently from the embedded one.
Comment 2 ian.merrithew 2010-06-05 02:49:37 UTC
Database name is amarok; user name is amarok; user amarok has every assigned privilege I can find in the MySQL Administrator. Plus, if it were a permissions problem, would you not expect that saving tag/rating info from any part of amarok would fail, as opposed to only specific parts?
Comment 3 Myriam Schweingruber 2010-06-05 18:00:17 UTC
Thank you for the feedback.
Comment 4 Jeff Mitchell 2010-07-01 22:13:51 UTC
I can't replicate this. Using current git, mysql 5.1.46.
Comment 5 Thomas Kahle 2010-09-11 00:59:46 UTC
I can reproduce this with amarok-2.3.1, external mysql 5.1.50. I recently migrated to external mysql and have the problem since then. Any ratings that are changed 'via plasmoids' are not persistent. However. When I open a single song's info and change the rating there it will be saved to the database. 
Can you please reopen this bug?
Comment 6 Jeff Mitchell 2010-09-11 02:02:08 UTC
I'll reopen, but changing the component.
Comment 7 Thomas Kahle 2010-09-13 16:39:49 UTC
Hmm, a reboot later it seems to work. Now I can't reproduce this anymore. Weird. When I had the issue I tried restarting the mysql server and restarting amarok, but that did not help. For me it's gone for now.
Comment 8 Jeff Mitchell 2010-09-14 12:25:10 UTC
I'm not sure why you keep focusing on the mysql database, but as you found in #5 the issue has to do with the plasmoid, not the database...
Comment 9 Thomas Kahle 2010-09-14 21:43:38 UTC
Well, I never had this problem while I was using embedded mysql in a file. It was triggered when I migrated to external mysql. That's why I would say the current summary misses that point.
Comment 10 ian.merrithew 2010-09-14 22:23:03 UTC
As the original bug reporter, I will confirm what Thomas says. This bug only happens when using an external mysql database. When using the embedded database it does not happen.

I can also confirm, per comment #7, that this bug is intermittent. It went away on me for quite a while, then resurfaced again recently, then went away again. I can't pin down the circumstances that are triggering it.
Comment 11 Jeff Mitchell 2010-09-15 01:24:52 UTC
If the bug is intermittent, then I would need proof that it's triggered by the external database.

The code in Amarok for external vs. internal is almost entirely the same -- all that is different is simply the original calls that connect to the database. The only difference I've ever seen between the two databases is if one of them simply doesn't work at all (like if there are issues connecting to it).

Maybe it's possible that your distro packages have some strange problem with mysql embedded vs. external, but that would be a super strange bug.
Comment 12 Myriam Schweingruber 2010-09-21 15:25:31 UTC
*** Bug 251908 has been marked as a duplicate of this bug. ***
Comment 13 Myriam Schweingruber 2010-09-21 15:26:18 UTC
Confirmed by duplicate.
Comment 14 Tom Deblauwe 2010-09-21 16:45:32 UTC
Hello,

I filed the duplicate bug. Now I find that it works... don't know what happened really. I just restarted the app, than it ran for a while, and when reading this bugreport I checked the database page in the config settings. Didn't really change anything there, only viewed it. Now it works.
Comment 15 Tom Deblauwe 2010-09-21 16:49:44 UTC
forgot to add: the "use external mysql database" setting was turned off on the database page.
Comment 16 Jeff Mitchell 2010-09-21 17:17:48 UTC
Tom, in comments #14 and #15 you clearly lay to rest the idea that this has anything to do with internal vs. external database.

Can we please not focus on the database as the issue here? All actual evidence instead points to issues with the plasmoid.
Comment 17 Myriam Schweingruber 2010-11-02 12:19:32 UTC
Is this still valid with current 2.4-git? I can't reproduce this here at all (never could earlier either, btw).
Comment 18 Myriam Schweingruber 2010-12-13 18:10:47 UTC
I can't reproduce this here at all, most likely already fixed.