Created attachment 47588 [details] patch to version 1.2.0 Version: 1.2.0 (using KDE 4.4.3) OS: Linux I have implemented caption export for the smugmug exporter. I tested it with KDE. In order to get multi-line/unicode captions to work I had to modify the exporter to use the multi-part form method similar to the flickr exporter. Attached is the patch against 1.2.0. All testing was done with kphotoalbum. What do I need to do to get this patch included in the official tree? I'm happy to tweak the code to comply with coding guidelines etc. Reproducible: Always
Are you sure that code compile against current implementation from svn trunk (next 1.3.0 release). Please checkout code from svn trunk following this page : http://www.digikam.org/drupal/download?q=download/KDE4 Thanks in advance Gilles Caulier
Well, the patch applies cleanly. But following the directions on the digikam page I am still unable to build anything. I just have these checked out: tnewsome@nelson20:~/kde$ ls graphics kdegraphics Is there other KDE stuff I need? I started looking at some other page a while back but it wanted me to get a million things and set up a whole parallel KDE development setup, which was more heavy weight than I was interested in. Is that the only way to check against svn?
Not sure what I did wrong before, but this time around I managed to get it to build. I've confirmed that the patch attached applies cleanly to the svn I checked out yesterday, and it even compiles and works correctly. What's the next step to getting it submitted?
SVN commit 1134010 by cgilles: apply patch #47588 from Tim Newsome to support Caption with SmugExport tool BUGS: 240420 M +1 -0 CMakeLists.txt M +1 -1 TODO AM mpform.cpp [License: GPL (v2+)] AM mpform.h [License: GPL (v2+)] M +1 -2 plugin_smug.cpp M +1 -1 plugin_smug.h M +6 -5 smugalbum.cpp U smugalbum.h M +95 -26 smugtalker.cpp M +24 -14 smugtalker.h M +8 -14 smugwidget.cpp U smugwidget.h M +6 -4 smugwindow.cpp M +1 -1 smugwindow.h WebSVN link: http://websvn.kde.org/?view=rev&revision=1134010