Bug 239825 - Filelight does not stop at file system boundaries
Summary: Filelight does not stop at file system boundaries
Status: RESOLVED FIXED
Alias: None
Product: filelight
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: Gentoo Packages Linux
: NOR minor
Target Milestone: ---
Assignee: Martin Sandsmark
URL:
Keywords:
: 239826 239999 270153 (view as bug list)
Depends on:
Blocks:
 
Reported: 2010-05-28 07:00 UTC by Frank Steinmetzger
Modified: 2013-12-11 11:37 UTC (History)
11 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
Output of filelight and other stuff (15.51 KB, text/plain)
2010-05-30 04:42 UTC, Frank Steinmetzger
Details
Console output of SVN version (9.34 KB, text/plain)
2010-05-30 19:06 UTC, Frank Steinmetzger
Details
Patch to make exclude list work again (830 bytes, patch)
2013-02-12 10:11 UTC, dag
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Frank Steinmetzger 2010-05-28 07:00:08 UTC
Version:           unspecified (using KDE 4.4.3) 
OS:                Linux

I have unchecked the option to scan across filesystem boundaries and I explicitly added /mnt to the directories to exclude. However, when I scan /, at some point my external HDD, which is mountet at /mnt/tc1, begins rattling. So obviously, Filelight still scans it inspite of being told not to at two different places.

Program version is 1.9rc3

Reproducible: Always



Expected Results:  
The external drive should not be scanned, the scan result should only show the content of the root partition.
Comment 1 Frank Steinmetzger 2010-05-28 07:14:28 UTC
*** Bug 239826 has been marked as a duplicate of this bug. ***
Comment 2 Martin Sandsmark 2010-05-29 16:23:58 UTC
Can you print out the console output?

And maybe try with the SVN version (I updated it to use Solid to get available partitions)?
Comment 3 Frank Steinmetzger 2010-05-29 21:37:38 UTC
I think the relevant, but omitted part on my side, was that the external drive was a truecrypt volume. I reset the list for dirs Filelight should skip to default and rescanned - it also skipped /home correctly.

Only it still included the two removable media I had inserted at that time - a USB key and a card reader. But other than those media, the Truecrypt volume didn’t show up in the overview screen.

Here's the shortened output of a scan where the Truecrypt volume was not mounted (less the mentions of inadequate access permissions and the process column):

Filelight::ScanManager::start: Scan requested for:  "file:///"
Filelight::LocalLister::scan: Tree pre-completed:  "/sys/"
Filelight::LocalLister::scan: Tree pre-completed:  "/proc/"
Filelight::LocalLister::scan: Tree pre-completed:  "/proc/"
Filelight::LocalLister::scan: Tree pre-completed:  "/root/"
Filelight::LocalLister::scan: Tree pre-completed:  "/dev/"
Filelight::LocalLister::scan: Tree pre-completed:  "/media/X-Plane/"
Filelight::LocalLister::scan: Tree pre-completed:  "/media/Musik/"
Filelight::LocalLister::scan: Tree pre-completed:  "/media/c-ntfs/"
Filelight::LocalLister::scan: Tree pre-completed:  "/media/d-ntfs/"
Filelight::LocalLister::scan: Tree pre-completed:  "/boot/"
Filelight::LocalLister::scan: Tree pre-completed:  "/var/tmp/portage/"
Filelight::LocalLister::scan: Tree pre-completed:  "/home/"
Filelight::LocalLister::run: Emitting signal to cache results ...
Filelight::LocalLister::run: Thread terminating ...
Filelight::ScanManager::cacheTree: Waiting for thread to terminate ...
Filelight::ScanManager::cacheTree: Thread terminated!


There's no mention of either removable media, which are mounted at /media/ISOCHIP and /media/disk, respectively.


Entries in "Do not scan these directories:"
/dev/
/proc/
/sys/
/root/

As for SVN - I couldn’t find out how to get it without pulling the entire KDE playground, which would be overkill for my connection.
Comment 4 Martin Sandsmark 2010-05-30 03:50:39 UTC
Please don't shorten the output. :-)

What I'm interested in is something like this (here I don't have any filesystems mounted that are not mentioned in the fstab):

filelight(7878) Filelight::LocalLister::readMounts: FSTAB:  devpts
filelight(7878) Filelight::LocalLister::readMounts: FSTAB:  tmpfs
filelight(7878) Filelight::LocalLister::readMounts: FSTAB:  ext3
filelight(7878) Filelight::LocalLister::readMounts: FSTAB:  swap
filelight(7878) Filelight::LocalLister::readMounts: FSTAB:  ext3
Comment 5 Frank Steinmetzger 2010-05-30 04:42:00 UTC
Created attachment 47470 [details]
Output of filelight and other stuff

Ah, my bad, I haven’t noticed the readMounts at the top because of those many QPainter events. So here it is with _all_ output during the scan, plus my fstab and mount information.
Comment 6 Martin Sandsmark 2010-05-30 13:47:29 UTC
Hmm, it seems like Filelight is unable to parse the fstab correctly and detect all your mounted filesystems.

I have changed Filelight to use Solid to get the mounted filesystems, in SVN. There should be an ebuild for Filelight from SVN, otherwise I plan on releasing a new version any day now.
Comment 7 Frank Steinmetzger 2010-05-30 19:06:04 UTC
Created attachment 47491 [details]
Console output of SVN version

To me it seems it parsed the fstab alright. My storage media devices are not in it, because they get dynamically mounted by hal through KDE’s device manager.

Anyhoo, I installed the SVN ebuild. Now it detects all filesystems at startup (see attached output).
But I’m afraid it’s currently a regression, because on the other hand, it scanned my entire system this time. It included all sub-mounts that were not explicitly listed in "Do not scan...".
Comment 8 Martin Sandsmark 2010-07-15 00:19:03 UTC
*** Bug 239999 has been marked as a duplicate of this bug. ***
Comment 9 MySh 2011-03-02 13:49:56 UTC
Have the same problem (KDE version: 4.6.0; Filelight version: 1.9).
Comment 10 lambda512 2011-04-05 15:34:37 UTC
*** Bug 270153 has been marked as a duplicate of this bug. ***
Comment 11 Jekyll Wu 2011-08-06 23:13:08 UTC
*** This bug has been confirmed by popular vote. ***
Comment 12 dE 2012-01-29 08:44:41 UTC
This bug still persists.
Comment 13 aditsu 2012-07-16 13:14:53 UTC
Bug still happening in kde 4.8.3/Gentoo (filelight 1.11)
Comment 14 dE 2012-07-19 04:37:49 UTC
Yeah.
Comment 15 Martin Sandsmark 2012-12-30 19:29:59 UTC
can any of you test with latest git? I can't reproduce after applying the patch from bug 312178.
Comment 16 Marco Poletti 2012-12-31 11:14:01 UTC
Now it works for me, using today's filelight from git.
Comment 17 Martin Sandsmark 2012-12-31 14:14:16 UTC
I'll mark this as fixed, then. Sorry it took so long.
Comment 18 dag 2013-02-12 08:22:05 UTC
Filelight from KDE 4.10.0
Pressing scan for / will still scan everything. Including my automounted NFS partitions

Checked that the mentioned patch is in the code. But it doesn't seem to help here
Comment 19 dag 2013-02-12 10:11:03 UTC
Created attachment 77194 [details]
Patch to make exclude list work again
Comment 20 clickwir631 2013-05-27 17:18:51 UTC
I have 2 NFS shares mounted in fstab and they are scanned when scanning /. I have them both listed in the "Do not scan these folders" option. I've tried with and without "Scan across filesystem boundaries" and with and without "Exclude remote filesystems". No matter the setting, they are scanned and displayed.

Filelight 1.13
KDE 4.10.2
Kubuntu 13.04 64bit
Comment 21 chhamann 2013-07-24 07:25:16 UTC
Same problem here. I have one NFS share at /mnt/server/ and an exclude entry in filelight for this path but it will be scanned. Please reopen this bug, it's not solved!
Comment 22 Christoph Feck 2013-08-11 09:40:22 UTC
No need to reopen, there is already bug 318925 open for this regression.
Comment 23 aditsu 2013-08-20 11:40:39 UTC
(In reply to comment #22)
> No need to reopen, there is already bug 318925 open for this regression.

How is bug 318925 related to this regression? There are 2 different problems (fs boundaries and explicit "do not scan" list). Or are you saying they have the exact same root cause?
Comment 24 jockie 2013-12-09 15:41:45 UTC
Filelight does not treat FUSE mount points as a different fs.

Using Filelight 1.13 under 32-bit Ubuntu 13.04 (KDE 4.10.5).
Comment 25 Martin Sandsmark 2013-12-10 11:50:55 UTC
Please don't comment on bugs closed as fixed unless you're using at least the version it is marked as fixed in...
Comment 26 aditsu 2013-12-10 12:23:05 UTC
(In reply to comment #25)
> Please don't comment on bugs closed as fixed unless you're using at least
> the version it is marked as fixed in...

Actually, he is using at least the version it is marked as fixed in. 4.10.5 is at least nil.
As far as I know, this bug is not fixed at all, but I'd like to be proven wrong.
Comment 27 Martin Sandsmark 2013-12-10 12:34:07 UTC
(In reply to comment #26)
> Actually, he is using at least the version it is marked as fixed in. 4.10.5
> is at least nil.
> As far as I know, this bug is not fixed at all, but I'd like to be proven
> wrong.

Because he's committing on an old bug with something that was a regression, tracked in another bug, which was fixed in 4.11, if you read the earlier comments here.
Comment 28 aditsu 2013-12-11 08:04:48 UTC
(In reply to comment #27)
> Because he's committing on an old bug with something that was a regression,
> tracked in another bug, which was fixed in 4.11, if you read the earlier
> comments here.

I read all the earlier comments. There's only a mention of the bug being fixed in the latest git, but nothing at all about the fix making it into any KDE version. What "another bug" are you talking about? (If you mean comment 22 then please read comment 23)
Comment 29 Martin Sandsmark 2013-12-11 11:19:22 UTC
There is only one ignore list in Filelight. It is automatically populated with filesystem mount points if that checkbox is enabled.
Comment 30 jockie 2013-12-11 11:37:11 UTC
I guess we're wasting way more lines in bug tracking than the code for the fix itself has/had.

I commented on this bug since the fields «See Also», «Latest Commit» and «Version Fixed In» at the upper right are EMPTY though the bug is marked as RESOLVED FIXED.

Also … in my case, filelight DID ignore a TrueCrypt-mounted «other filesystem» BUT still decended into the «««FUSE-mounted»»» file systems. So to clear up my contribution.