Bug 238942 - Overwrite/Rename dialogue badly designed
Summary: Overwrite/Rename dialogue badly designed
Status: RESOLVED FIXED
Alias: None
Product: kio
Classification: Unmaintained
Component: general (show other bugs)
Version: SVN
Platform: Arch Linux Linux
: NOR wishlist
Target Milestone: ---
Assignee: David Faure
URL:
Keywords: junior-jobs
Depends on:
Blocks:
 
Reported: 2010-05-26 23:30 UTC by Xaver Wurzenberger
Modified: 2010-10-12 01:00 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In: 4.6
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Xaver Wurzenberger 2010-05-26 23:30:55 UTC
Version:           unspecified (using KDE 4.4.3) 
OS:                Linux

Hi,
this isn't really a bug, I know. But it's something that will leave quite some people confused:
When copying same-name files, dolphin opens a dialogue asking if "the file on the left" should really be overwritten with "the file on the right". So far, so good. But implemented is also a funtion to rename the file. This (i.e., the textedit) sits right under the left ("old") file so I thought I was renaming the left one and I didn't realize until a few files later... I know it's actually logical which one will be renamed, but please consider redesigning a little as this should be a very common mistake, especially if someone overlooks the top text.
Also, this dialogue should not be blocking all of the dolphin instances. This made discovering my error harder, as I had to find another file manager first!

Reproducible: Always
Comment 1 Steven Sroka 2010-09-18 23:53:37 UTC
Hey, I loved to take over this wish. I need some help finding the source code though. This is my first time coding for KDE, I can't wait to start. David, I think you are assigned this report, what do you think?
Comment 2 Steven Sroka 2010-09-19 05:53:10 UTC
Hmmm.... I found the source code: http://websvn.kde.org/trunk/KDE/kdelibs/kio/kio/renamedialog.cpp?revision=1170488&view=markup

And my apologies, Holger Freyther is the one running the show now.
Comment 3 Steven Sroka 2010-10-09 23:59:28 UTC
Davis, can you close this once you commit my fix?
Comment 4 David Faure 2010-10-12 01:00:07 UTC
Well it actually renames the file on the left (in its new place), not the file on the right :-)
Comment 5 David Faure 2010-10-12 01:00:20 UTC
SVN commit 1184956 by dfaure:

Applied patch from Steven Sroka "Minor GUI change to rename/overwrite dialog window"
REVIEW: 5443
BUG: 238942


 M  +113 -63   renamedialog.cpp  
 M  +5 -2      renamedialog.h  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1184956