Bug 238736 - [PATCH] collection browser should filter ratings by values between 0 and 5
Summary: [PATCH] collection browser should filter ratings by values between 0 and 5
Status: RESOLVED INTENTIONAL
Alias: None
Product: amarok
Classification: Applications
Component: Collection Browser (show other bugs)
Version: 2.3.0.90
Platform: openSUSE Linux
: NOR minor
Target Milestone: 2.3.2
Assignee: Amarok Developers
URL:
Keywords: usability
Depends on:
Blocks:
 
Reported: 2010-05-24 21:58 UTC by Daniel Faust
Modified: 2010-05-25 14:16 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:

Attachments
multiply user input by 2 (742 bytes, patch)
2010-05-24 21:59 UTC, Daniel Faust 		Details
View All Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Faust 2010-05-24 21:58:00 UTC 
Version:           2.3.0.90 (using KDE 4.3.5) 
OS:                Linux

at the moment the user has to filter by values between 0 and 10 but this is not consistent with the 5 star system. this patch converts the float input from the user to the int value for internal handling.

Reproducible: Didn't try
Comment 1 Daniel Faust 2010-05-24 21:59:19 UTC 
Created attachment 43856 [details]
multiply user input by 2
Comment 2 Myriam Schweingruber 2010-05-25 10:42:31 UTC 
Sorry, but I don't think we will use that, half a star is one point, and you can rate by half a star, this has always been like that in all Amarok versions and is on purpose.
Comment 3 Sven Krohlas 2010-05-25 14:16:06 UTC 
Daniel, fyi: this just started a discussion on our amarok-devel mailing list:
http://mail.kde.org/pipermail/amarok-devel/2010-May/007124.html

We need to keep consistency across the application. So at least this patch needs to change all places where users can input rating information (dynamic and automatic playlist, tag dialog, etc). If the team agrees to change it this way.