Bug 238695 - url passes rss, kget icons which looks ugly
Summary: url passes rss, kget icons which looks ugly
Status: RESOLVED FIXED
Alias: None
Product: rekonq
Classification: Unmaintained
Component: general (show other bugs)
Version: latest git snapshot
Platform: Ubuntu Linux
: NOR wishlist
Target Milestone: ---
Assignee: Andrea Diamantini
URL:
Keywords:
Depends on:
Blocks: 237890
  Show dependency treegraph
 
Reported: 2010-05-24 17:12 UTC by m.wege
Modified: 2010-09-04 10:01 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments
screenshot showing the problem (3.83 KB, image/png)
2010-05-24 17:12 UTC, m.wege
Details

Note You need to log in before you can comment on or make changes to this bug.
Description m.wege 2010-05-24 17:12:34 UTC
Created attachment 43849 [details]
screenshot showing the problem

Version:           unspecified (using KDE 4.4.3) 
OS:                Linux

If the url is long it does not stop at the point where the icons for rss, kget are in the urlbar. The url flow underneath them. That looks really ugly. Would be great if this could be changed.

Reproducible: Always




OS: Linux (i686) release 2.6.32-22-generic-pae
Compiler: cc
Comment 1 Panagiotis Papadopoulos 2010-05-24 17:21:12 UTC
Confirmed.
What we could do is let the text fade out, when it comes near the icons, similar like it is done in KMess' window, when the status message is "touching" the window border.
Comment 2 m.wege 2010-05-24 19:09:53 UTC
Yes that it is a possibility. Additionally it would make sense to have this special area of icons which relate to the current page also have an own background colour which should be made in way that it still indicates that it still belongs to the urlbar.
Comment 3 Panagiotis Papadopoulos 2010-05-24 21:42:25 UTC
http://trac.kmess.org/browser/src/widgets/gradientelidelabel.cpp

There's the code for the text fading "magic" :)
Might be helpful
Comment 4 Andrea Diamantini 2010-05-26 12:07:47 UTC
uhm... pano, one better link (without studying all kmess code)?
Thanks ;)
Comment 5 Andrea Diamantini 2010-06-03 12:32:39 UTC
commit 9e5e6d59b75a5188620fd5428af37f61bb812b0c
Author: Andrea Diamantini <adjam7@gmail.com>
Date:   Thu Jun 3 12:34:06 2010 +0200

    This easy solution should fix problems with long urls that pass right icons
    
    BUG:238695

diff --git a/src/urlbar/urlbar.cpp b/src/urlbar/urlbar.cpp
index b46eccd..33515de 100644
--- a/src/urlbar/urlbar.cpp
+++ b/src/urlbar/urlbar.cpp
@@ -303,7 +303,12 @@ void UrlBar::loadFinished()
         connect(bt, SIGNAL(clicked(QPoint)), _tab->page(), SLOT(showSSLInfo(QPoint)));
     }
 
-    update();
+    // we need to update urlbar after the right icon settings
+    // removing this code (where setStyleSheet automatically calls update) needs adding again 
+    // an update call
+    kDebug() << "resetting stylesheet";
+    int rightIconWidth = 25 * (_rightIconsList.count());
+    setStyleSheet(QString("UrlBar { padding: 0 %2px 0 %1px;} ").arg(_icon->sizeHint().width()).arg(rightIconWidth));
 }