Bug 238502 - Investment Price Graph report shows price=1.00 prior to first buy
Summary: Investment Price Graph report shows price=1.00 prior to first buy
Status: RESOLVED FIXED
Alias: None
Product: kmymoney
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: Ubuntu Linux
: NOR normal
Target Milestone: ---
Assignee: KMyMoney Devel Mailing List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-05-22 16:35 UTC by Jan
Modified: 2010-06-01 03:15 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jan 2010-05-22 16:35:41 UTC
Version:           1.0.4 (using KDE 4.3.5)
OS:                Linux
Installed from:    Ubuntu Packages

The price of an investment prior to the date of first entry shows up as 1.00, with a vertical line to the correct price on the date of first entry.  Better would be to start the graph for that investment at the time the first quote is available (i.e. first buy) and no graph at all for prior dates.
Comment 1 Alvaro Soliverez 2010-05-28 16:27:39 UTC
By default, any share without a price has a price of 1.00.

It can be modified to show 0.00 prior to the first price. What it won't do is modify the report dates. 
If the user wants to display a certain date, the application won't claim to be smarter. Also, there are cases where the user enter a stock but not a price. This is way a good way to show that data is missing.
Comment 2 Jan 2010-05-29 15:23:16 UTC
I agree KMM should not change the date range and very much appreciate it does not try to be smarter than the user.  However, if you display multiple curves in the same chart, changing the range is not even an option.  If the date range goes back far enough, there may be as many starting dates as there are curves in the graph, each corresponding to the day a security was first entered.  Showing an incorrect price of 1.00 in my opinion is not the best way to indicate data is missing.  Not showing anything is!  I wonder if anybody else out there has an opinion on this?

Thanks.
Comment 3 David Houlden 2010-05-29 15:48:38 UTC
For me, showing a price of zero rather than 1.00 would be an improvement although still not ideal. If the stock price is actually close to 1.00 then defaulting to 1.00 for missing data is confusing.
For the wishlist, the line should only start at the date of the earliest available price.
Comment 4 Alvaro Soliverez 2010-05-29 17:51:18 UTC
As I said before, the fix will show a price of 0.00, before the first price, for the price reports. 
I'll also look into adding a test to the consistency check to inform the user about this.

As I said before too, I'm against reconfiguring the report automatically for the user. This point has been brought before on other issues, and between doing something automatically or trusting the user's input, I'll stick to the latter.
Comment 5 David Houlden 2010-05-29 18:40:30 UTC
I wasn't disagreeing with your earlier comment Alvaro. I agree totally about not reconfiguring the report automatically in terms of date ranges. That should be up to the user to set the date range they want. Just to make it clear, my ideal solution would be that the line representing an investment's value or price should only be shown on the graph from the point at which a price is available. This means that the line may not start at the left edge of the x-axis. Of course this may not be possible with the KDE chart libraries.
Comment 6 Jan 2010-05-29 19:39:59 UTC
David: you are expressing exactly what I mean.  If I have a chart starting at day 01/01/2009 and ending at day 05/31/2010, displaying the price of 5 different investments in that period, I do not expect all curves to start exactly on M1D1Y1.  I certainly agree that the start and end days of the graph should be as the user defined, but the availability of data is independent of that.  If a given investment first appears (with a price) on 11/01/2009, and another one on 03/27/2010, I would expect these two curves to start only at those respective days.

Likewise, curves should stop on the last day a price is available.  I have not checked what KMM does, but it would be incorrect to extrapolate a price line, e.g. at a constant price.

Jan
Comment 7 Alvaro Soliverez 2010-05-29 22:08:39 UTC
SVN commit 1132127 by asoliverez:

For the price graphs, only show data if there is an actual price for it

BUG:238502

 M  +58 -1     pivottable.cpp  
 M  +5 -0      pivottable.h  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1132127
Comment 8 Alvaro Soliverez 2010-06-01 03:15:53 UTC
SVN commit 1133051 by asoliverez:

Fix date comparison and add consistency checks for prices.

BUG:238502

 M  +66 -1     mymoney/mymoneyfile.cpp  
 M  +2 -2      reports/pivottable.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1133051