Bug 238373 - Konsole has too easy shortcut to extremely dangerous functionality
Summary: Konsole has too easy shortcut to extremely dangerous functionality
Status: RESOLVED FIXED
Alias: None
Product: konsole
Classification: Applications
Component: general (show other bugs)
Version: 2.4.2
Platform: Ubuntu Linux
: NOR normal
Target Milestone: ---
Assignee: Konsole Developer
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-05-21 10:32 UTC by Thomas Damgaard
Modified: 2010-06-01 02:01 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Thomas Damgaard 2010-05-21 10:32:32 UTC
Version:           2.4.2 (using KDE 4.4.2)
OS:                Linux
Installed from:    Ubuntu Packages

Yesterday I learned about a "feature" in Konsole that had nearly ruined several servers in critical productions systems.

I use Konsole every day to ssh to servers and perform system maintenance and development work.

Yesterday I had ssh connections open to several production servers. Each session in a different Konsole tab. We had some strange problems on a database server where I needed to to some strace and ltrace and some work inside a chroot. Konsole has a shortcut to "New tab" on Shitf+Ctrl+n and "New Window" on Shift+Ctrl+m. At some point, I must have hit Shift+Ctrl+, (comma is just next to n on the keyboard). I did not notice that I hit ',' and continued my work. 

Well... Suddenly a lot of things started to act weird. I had co-worker come and see. For instance, a process that I started would always start two instances and there was a race condition on who would bind to a tcp port. After a while, we figured out that somehow the feature "Copy Input To > All Tabs in current window" was enabled. The shortcut for this functionality was -- ctrl+shift+,.

This means that *every command that I wrote in one of my ssh sessions were also run on EVERY open ssh session on different servers*. In several of the sessions I was logged in as root. As you can imagine, this could have been a disaster.

After the fact, we noticed that a little red exclamation mark appeared in the tab. However, this exclamation mark did not have any help text or anything. Also, none of us noticed it before it was too late.


Although useful, this is an *extremely* dangerous feature. It should definitely be more difficult to turn on. At least it should not have a shortcut that are 1 key away from a harmless and frequently used feature like "new window". 

Possible solutions:
1: Remove the shortcut mapping for this feature. This way, people who use it can set a shortcut themselves, if they need it. My guess is that, even if you use this feature, you use it seldom. (I myself use clusterssh for these purposes).

2: Set the shortcut key to something different. Preferably more difficult to hit by accident. Mayby involving both Ctrl+Shift+Alt.

3: Make the feature more "noisy". The tiny red exclamation mark in the tab is way too descrete. Have an alert box open and explain that the feature was turned on. Make the user click OK. Maybe with an option not see this message again. Maybe keep the red exclamation mark also, but add some help text to it, so that an explanation appears when you hover it with the mouse cursor.

#3 could be combined with 1 or 2.


I really hope that you will look into this. It is only a matter of time before this will cause serious data loss or worse for someone.
Comment 1 Sascha Peilicke 2010-05-21 12:37:10 UTC
At the least the shortcuts for new window/tab where changed to KDE defaults, CTRL+SHIFT+M isn't used anymore.
Comment 2 Christian Iversen 2010-05-24 15:33:29 UTC
*** This bug has been confirmed by popular vote. ***
Comment 3 Kurt Hindenburg 2010-06-01 00:47:19 UTC
SVN commit 1133027 by hindenburg:

Remove the shortcut to send all output to current windows.  This might catch people off guard if they accidently hit it.  People who want it can just re-assign it back.

CCBUG: 238373


 M  +0 -1      SessionController.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1133027
Comment 4 Kurt Hindenburg 2010-06-01 02:01:28 UTC
SVN commit 1133042 by hindenburg:

Remove the shortcut to send all output to current windows.  This might catch people off guard if they accidently hit it.  People who want it can just re-assign it back.

BUG: 238373


 M  +0 -1      SessionController.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1133042