Bug 238150 - scangui is untranslated, because it loads no reqired translation catalog
Summary: scangui is untranslated, because it loads no reqired translation catalog
Status: RESOLVED FIXED
Alias: None
Product: libksane
Classification: Frameworks and Libraries
Component: general (show other bugs)
Version: unspecified
Platform: Compiled Sources Unspecified
: NOR normal
Target Milestone: ---
Assignee: imaging-bugs-null
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-05-19 11:45 UTC by Burkhard Lück
Modified: 2015-09-17 09:29 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In: 1.3.0


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Burkhard Lück 2010-05-19 11:45:20 UTC
Version:            (using Devel)
Installed from:    Compiled sources

scangui does not load any translation catalog beside the system catalogs. 
To be fully translated it needs to load the catalogs libksane, sane-backends and kipiplugin_acquireimages as the kipi plugin acquireimages does.
Comment 1 caulier.gilles 2010-05-27 12:09:35 UTC
No. catalogs are loaded by libksane. scangui use it internally. 

Look there :

http://lxr.kde.org/source/KDE/kdegraphics/libs/libksane/libksane/ksane_widget.cpp#88

Gilles Caulier
Comment 2 Burkhard Lück 2010-05-27 14:08:01 UTC
You are right, it loads libksane and sane-backends via ksane_widget.cpp, sorry for the false alarm.

But what is really missing are the messages in kipi-plugins/acquireimages (catalog name is kipiplugin_acquireimages).

scangui tries to load the non existing catalog "scangui" instead, via the appname "scangui"?
Comment 3 caulier.gilles 2010-05-27 14:21:09 UTC
SVN commit 1131128 by cgilles:

set main catalog from acuireimages kipi-plugins
CCBUGS: 238150


 M  +2 -0      scangui.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1131128
Comment 4 caulier.gilles 2010-05-27 14:26:03 UTC
Burkhard,

It must be fixed now in svn. Please checkout and test

Gilles
Comment 5 Pino Toscano 2010-05-27 14:43:00 UTC
Please do not use setMainCatalog() in plugins, but insertCatalog(), otherwise it will create problems to the host application loading such plugins.
Comment 6 caulier.gilles 2010-05-27 14:46:52 UTC
Pino,

scangui is a stand alone version of the plugin. the main.cpp is not included in plugin code. it's completely separated.

Gilles
Comment 7 Pino Toscano 2010-05-27 14:56:30 UTC
Ok. Note you can set the main application catalog for example by specifying it in the KAboutData of the application (second parameter of its constructor).
Comment 8 Burkhard Lück 2010-05-28 08:54:33 UTC
(In reply to comment #4)
> 
> It must be fixed now in svn. Please checkout and test
> 
No, that does not work, scangui is still untranslated and tries to load the catalog scangui.

Only with "cp kipiplugin_acquireimages.mo scangui.mo" I have the startdialog translated.

You can easily verify that bug by using language x-test (http://techbase.kde.org/Development/Tutorials/Localization/Building_KDE's_l10n_Module#Step_2:_l10n), developed by Coolo for this purpose.
Comment 9 Burkhard Lück 2010-05-28 09:15:55 UTC
SVN commit 1131425 by lueck:

load translation catalog properly
BUG:238150

 M  +1 -2      scangui.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1131425