Bug 238119 - desktop effects 'all effects' selection not rembered when switching tabs
Summary: desktop effects 'all effects' selection not rembered when switching tabs
Status: RESOLVED INTENTIONAL
Alias: None
Product: kwin
Classification: Plasma
Component: compositing (show other bugs)
Version: unspecified
Platform: Compiled Sources Linux
: NOR normal
Target Milestone: ---
Assignee: KWin default assignee
URL:
Keywords:
: 170371 269630 (view as bug list)
Depends on:
Blocks:
 
Reported: 2010-05-19 03:23 UTC by SlashDevDsp
Modified: 2015-01-13 12:05 UTC (History)
4 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
Patch against v4.7.2 tag (2.88 KB, application/octet-stream)
2012-07-22 23:48 UTC, groot
Details
All effects tab no more lose its settings (842 bytes, patch)
2012-07-23 16:47 UTC, Antonis Tsiapaliokas
Details

Note You need to log in before you can comment on or make changes to this bug.
Description SlashDevDsp 2010-05-19 03:23:45 UTC
Version:            (using Devel)
Compiler:          g++ 4.3 
OS:                Linux
Installed from:    Compiled sources

User option selection for the 'All effects' tab in systemsettings is not remembered after switching tabs.

1. systemsettings-> Desktop effects
2. Click the 'tick' for the 'Invert plugin' as example
3. Now select the 'Advanced' tab (you may or may not change any settings there) and select the 'All effects' tab, you see the 'tick' that you enabled for the 'Invert' plugin disappeared.
4. I believe this should not happen, i.e. you cannot change options on various tabs and finally click apply. instead you have to change all options on one tab click apply then move on to the other tab.
Comment 1 SlashDevDsp 2010-06-24 05:22:47 UTC
still present in today's svn
Comment 2 groot 2012-07-22 11:38:25 UTC
Still present in KDE 4.7.2 on OpenSuSE 12.1.

You do specifically need to go to the "Advanced" tab and right back, though:

- Start on "All Effects" tab with Invert unchecked. Check it, switch to General, switch to All Effects: the checkmark is still there. (OK)
- Start on "All Effects" tab with Invert checked. Uncheck it, switch to General, switch to All Effects: the checkmark is still gone. (OK)
- Start on "All Effects" with Invert unchecked. Check it, switch to Advanced, switch to All Effects: box unchecked. (BUG)
- Start on "All Effects" with Invert checked. Uncheck it, switch to Advanced, switch to All Effects: box is checked again. (BUG)
-Start on "All Effects" with Invert unchecked. Check it, switch to General, switch to Advanced, switch to All Effects: box is still checked. (OK)
- Start on "All Effects" with Invert checked. Uncheck it, switch to General, switch to Advanced, switch to All Effects: box is unchecked. (OK)
- Start on "All Effects" with Invert unchecked. Check it, switch to Advanced, then General, then All Effects again. Box is still checked. (OK)
- Start on "All Effects" with Invert checked. Uncheck it, Advanced, General, All Effects: Box is unchecked. (OK)
Comment 3 groot 2012-07-22 23:48:31 UTC
Created attachment 72688 [details]
Patch against v4.7.2 tag

The problem is in the tab-switching code (which already has a TODO saying that it's tricky). Basically switching to the advanced tab didn't save the settings of where it was coming from, and didn't load the advanced tab settings either. The patch adds m_previousTab which remembers which tab was shown previously (QTabWidget does not provide this information) when switching. It also #defines the magic indexes for the different tab pages.
Comment 4 Antonis Tsiapaliokas 2012-07-23 16:46:23 UTC
Hello,

I can reproduce this bug on master.

Reproduce steps:

1)Change something on the All effects tab
2)Go to Advanced Tab
3)The changes from "All Effects" tab are lost

Also i have tried the groot's patch but it didn't work. Also after applying the patch, The apply button was disable.

With the above patch i have fix the bug
Comment 5 Antonis Tsiapaliokas 2012-07-23 16:47:38 UTC
Created attachment 72708 [details]
All effects tab no more lose its settings
Comment 6 Martin Flöser 2012-07-23 16:54:27 UTC
my recommendation for this bug: rm -rf on the codebase, that is if we tackle 
the all effects for 4.10 I think we should also go for rewriting the backend 
code.

Why? Because the basic assumption of the module now longer holds. The complete 
code is written for the worst case which used to be kind of the regular case 
in 4.0: compositing does not work. Nowadays compositing works and if not KWin 
is strong enough to not leave the user in a broken system state. We haven't 
had report for really broken things for years.

So given that I think we can drop all the confirmation that it worked things 
and just assume that everything works. In consequence we don't need to save 
the previous stages and navigating between the tabs should not be an issue any 
more.
Comment 7 Thomas Lübking 2012-08-26 10:40:45 UTC
*** Bug 269630 has been marked as a duplicate of this bug. ***
Comment 8 Thomas Lübking 2012-08-26 10:40:51 UTC
*** Bug 170371 has been marked as a duplicate of this bug. ***
Comment 9 Martin Flöser 2015-01-13 12:05:14 UTC
In 5.x there is a new and rewritten kcm for effects which doesn't have tabs. Thus the problem described in this bug report doesn't apply any more. Because of that I change to WONTFIX, although one could also say it's fixed.