Bug 237849 - dynamic playlist adds titles not matching selected criteria
Summary: dynamic playlist adds titles not matching selected criteria
Status: RESOLVED FIXED
Alias: None
Product: amarok
Classification: Applications
Component: Playlists/Dynamic Playlists (show other bugs)
Version: 2.3.1
Platform: unspecified Linux
: NOR normal
Target Milestone: ---
Assignee: Amarok Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-05-16 18:33 UTC by Pascal Klein
Modified: 2011-08-31 13:35 UTC (History)
5 users (show)

See Also:
Latest Commit:
Version Fixed In: 2.4.3
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Pascal Klein 2010-05-16 18:33:31 UTC
Version:           2.3.0 (using 4.4.2 (KDE 4.4.2), Kubuntu packages)
Compiler:          cc
OS:                Linux (x86_64) release 2.6.32-22-generic

Some of the weighting features in the dynamic playlist are not working correctly.
If I try to let amarok only add tracks with a length greater than 30 minutes to my playlist it just does not do it. I have many sets which are one or two hours in length but amarok seems to like short tracks much more. In 15 added tracks there is only one matching my criteria. I always set "fixed weight" to match 100% of the playlist to what I want.

On the other hand selecting which rating the tracks need to have at minimum works perfectly. 

Rating, score and playcount seem to work, all the others like artist name, genre, year, etc. have the same effect as if they are disabled.
Comment 1 Sven Krohlas 2010-05-18 12:02:42 UTC
There have been a lot of dynamic playlist fixes since 2.3.0. Is this still a problem in 2.3.1 beta 1 or later?
Comment 2 Lamarque V. Souza 2010-06-04 04:38:46 UTC
It is not working well in 2.3.1. Depending on the criteria used it adds the same song more than once (sometimes even five times), it does not obey some criteria (number of executions in my test).
Comment 3 Myriam Schweingruber 2010-06-05 01:34:39 UTC
Well, if the amount of tracks available to match a criteria is too low it can well have several duplicate entries. Duplicates can happen in random mode, too, of course.
Comment 4 missive 2010-08-15 14:58:06 UTC
It is also broken with play count in 2.3.1

I have a Dynamic Playlist with one filter:

Proportion: 100%
Match: Play Count
With: equal to 0

But songs with play count greater than 0 are still being selected.
Comment 5 Ralf Engels 2010-08-21 12:35:00 UTC
Play count is working for me.
Track length is not.

Doublicate entries are easy to explain.
You don't have any bias which says: Song only once in playlist.
It's logical and fair (for the songs) but not very nice.

You could add a play count or last played bias to prevent doublicates, however the current version only updates your songs after they are played.
You would still get doublicates.
Comment 6 missive 2010-08-21 15:53:57 UTC
Yes, I thought about the possibility that "play count != 0" songs in the "play count = 0" playlist were just duplicates (ie, they were added to the list when their play count was 0 but were added to the list twice) but that does not seem to be the case.

Unless the actual dynamic playlist is longer than the visible playlist...

In other words; I have Previous=5 and Upcoming=10. If the dynamic playlist generator is actually generating 50 songs ahead but only showing 10 of them, it would be impossible to see the songs being added to the list properly. It would appear that they were being added to the list in contradiction to the applied filter.
Comment 7 missive 2010-08-27 20:16:22 UTC
I have found that clearing out the playlist, and then clicking the "On" checkbox and clicking "Repopulate" does select 100% match for Play Count equals 0.

So, I wonder if modifying a dynamic playlist while the playlist is operating is not actually taking effect until the playlist is stopped and started again.
Comment 8 Lamarque V. Souza 2010-08-27 20:28:44 UTC
I just wanted to know why preventing duplicates is not default. I think most people do not want duplicates when generating playlists, so why allowing duplicates is the default?

I am very frustrated about Amarok playlist generator, it is not intuitive (not even unintuitive, i must say it is very difficult to understand and even more to use) and has this insane duplicate default. I am really considering moving to another music player, maybe juk has a better playlist handling.
Comment 9 nik.knatterton 2011-08-31 12:37:48 UTC
I can confirm this problem with another criteria. My dynamic playlist is set up to only add songs which haven't been played for four months (100% fix weight).

Some song were just played a few hours before.

amaroK v. 2.4.0 on Kubuntu 11.04
Comment 10 Ralf Engels 2011-08-31 13:35:29 UTC
That bug is fixed for the current Amarok. Try 2.4.3 with the all new dynamic playlist.