Bug 237786 - whitebalance doesn't work properly
Summary: whitebalance doesn't work properly
Status: RESOLVED FIXED
Alias: None
Product: digikam
Classification: Applications
Component: Plugin-Editor-WhiteBalance (show other bugs)
Version: 1.2.0
Platform: Debian testing Linux
: NOR normal
Target Milestone: ---
Assignee: Digikam Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-05-16 06:12 UTC by Holger Wagemann
Modified: 2016-06-30 11:38 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In: 1.5.0


Attachments
Proposed patch to avoid the "infinite" spinning mouse cursor (368 bytes, patch)
2010-09-04 09:10 UTC, Berthier Lemieux
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Holger Wagemann 2010-05-16 06:12:38 UTC
Version:            (using KDE 4.4.3)
Compiler:          g++-4.4 & gcc-4.4 
OS:                Linux
Installed from:    Debian testing/unstable Packages

The new digikam and showfoto, build against KDE4.4.3 both don't work properly, 
when the kipi-plugin function "white-balance" is chosen. If confirm a working 
step there with ok, the photo is manipulated but I get a non-stop rotating 
mouse symbol (I suppose the symbol under KDE, which shows a working process 
and should stop, when the process is done). I only can stop this, if I close 
the whole digikam. I can reproduce this behavior on two further PCs.

My system is an up-to-date Debian Sid / sidux.
Comment 1 caulier.gilles 2010-05-16 10:02:33 UTC
Which digiKam version you use exactly ? Try last 1.2.0.

Gilles Caulier
Comment 2 Holger Wagemann 2010-05-16 11:01:15 UTC
(In reply to comment #1)
> Which digiKam version you use exactly ? Try last 1.2.0.
> 
> Gilles Caulier

I use digikam 1.2.0 and kipi-plugins 1.2.0:

apt-cache policy digikam kipi-plugins
digikam:
  Installiert: 2:1.2.0-2
  Kandidat: 2:1.2.0-2
  Versions-Tabelle:
 *** 2:1.2.0-2 0
        500 http://ftp.de.debian.org sid/main Packages
        100 /var/lib/dpkg/status
     2:1.1.0-1 0
        500 http://ftp.de.debian.org squeeze/main Packages
kipi-plugins:
  Installiert: 1.2.0-2
  Kandidat: 1.2.0-2
  Versions-Tabelle:
 *** 1.2.0-2 0
        500 http://ftp.de.debian.org sid/main Packages
        100 /var/lib/dpkg/status
     1.1.0-1 0
        500 http://ftp.de.debian.org squeeze/main Packages
holger@alpha:~$

With best regards,
  Holger
Comment 3 caulier.gilles 2010-05-16 12:13:39 UTC
I think i have fixed this problem in current implementation from svn (next 1.3.0 release)

Gilles Caulier
Comment 4 Holger Wagemann 2010-07-17 10:34:53 UTC
Hello,

on PC of my wife I've installed Mandriva 2010.1, they've integrated the last digikam and kipiplugins in version 1.3.0. But the error with white-balance still exists.

On debian I'm not able to compare because as I've understood the situation the maintainers don't like to integrate svn stuff from kdegraphics, which is obviously needed for the new digikam version, and so they don't integrate digikam 1.3.0.

With best regards,
  Holger
Comment 5 Holger Wagemann 2010-07-17 11:09:09 UTC
Additional comment: To help with further info I now download PClinxOS. Here we have the most actual kde, digikam and kipi stuff.

I'll give further feedback after testing with PClinuxOS.

With best regards,
  Holger
Comment 6 caulier.gilles 2010-07-17 12:34:13 UTC
Can you provide a photo to try to reproduce the problem ?

Also, give me the console trace when you use WB tool

Gilles Caulier
Comment 7 Thorsten Schnebeck 2010-08-29 22:54:08 UTC
Its still valid for digikam 1.3 + qt 4.7 Ubuntu-packages:

The white balance tool works as advertised. When pressing OK, the mouse pointer changes to a spinning working process indicator. The calculation ends correctly and the WB tool closes -> back to editor main window. 
But now the spinning mouse cursors stays inside of digikams edit view and digikams album view.
So there is a missing "switch back to std. mouse pointer at exit"

Here is the console log:
Here the whitebalance (Weißabgleich) tool is opened:
digikam(15462)/digikam (core) Digikam::EditorToolThreaded::slotEffect: Preview  "Weißabgleich"  started...
digikam(15462)/digikam (core) Digikam::WBFilter::setLUTv: T(K):  6500  => R: 1  G: 1  B: 1  BP: 0  WP: 256
digikam(15462)/digikam (core) Digikam::EditorToolThreaded::slotFilterFinished: Preview  "Weißabgleich"  failed...
digikam(15462)/digikam (core) Digikam::EditorToolThreaded::slotEffect: Preview  "Weißabgleich"  started...
digikam(15462)/digikam (core) Digikam::WBFilter::setLUTv: T(K):  6500  => R: 1  G: 1  B: 1  BP: 0  WP: 256
digikam(15462)/digikam (core) Digikam::EditorToolThreaded::slotFilterFinished: Preview  "Weißabgleich"  completed...

Now I change the WB:

digikam(15462)/digikam (core) Digikam::ImageRegionWidget::emitCapturedPointFromOriginal: Captured point from image :  QPoint(699,409)
digikam(15462)/digikam (core) Digikam::WBFilter::autoWBAdjustementFromColor: Sums:  R: 255  G: 251  B: 255
digikam(15462)/digikam (core) Digikam::WBFilter::autoWBAdjustementFromColor: Intermediate Temperature (K): 7000
digikam(15462)/digikam (core) Digikam::WBFilter::autoWBAdjustementFromColor: Intermediate Temperature (K): 4500
digikam(15462)/digikam (core) Digikam::WBFilter::autoWBAdjustementFromColor: Intermediate Temperature (K): 5750
digikam(15462)/digikam (core) Digikam::WBFilter::autoWBAdjustementFromColor: Intermediate Temperature (K): 6375
digikam(15462)/digikam (core) Digikam::WBFilter::autoWBAdjustementFromColor: Intermediate Temperature (K): 6687.5
digikam(15462)/digikam (core) Digikam::WBFilter::autoWBAdjustementFromColor: Intermediate Temperature (K): 6531.25
digikam(15462)/digikam (core) Digikam::WBFilter::autoWBAdjustementFromColor: Intermediate Temperature (K): 6453.12
digikam(15462)/digikam (core) Digikam::WBFilter::autoWBAdjustementFromColor: Intermediate Temperature (K): 6492.19
digikam(15462)/digikam (core) Digikam::WBFilter::autoWBAdjustementFromColor: Intermediate Temperature (K): 6511.72
digikam(15462)/digikam (core) Digikam::WBFilter::autoWBAdjustementFromColor: Intermediate Temperature (K): 6501.95
digikam(15462)/digikam (core) Digikam::WBFilter::autoWBAdjustementFromColor: Temperature (K): 6506.84
digikam(15462)/digikam (core) Digikam::WBFilter::autoWBAdjustementFromColor: Green component: 1.01668
digikam(15462)/digikam (core) Digikam::EditorToolThreaded::slotEffect: Preview  "Weißabgleich"  started...
digikam(15462)/digikam (core) Digikam::WBFilter::setLUTv: T(K):  6506.8  => R: 1  G: 1  B: 1  BP: 0  WP: 256
digikam(15462)/digikam (core) Digikam::EditorToolThreaded::slotFilterFinished: Preview  "Weißabgleich"  completed...

Now I press OK

digikam(15462)/digikam (core) Digikam::EditorToolThreaded::slotOk: Final  "Weißabgleich"  started...
digikam(15462)/digikam (core) Digikam::WBFilter::setLUTv: T(K):  6506.8  => R: 1  G: 1  B: 1  BP: 0  WP: 256
digikam(15462)/digikam (core) Digikam::EditorToolThreaded::slotFilterFinished: Final "Weißabgleich"  completed...

Does Digikam::EditorToolThreaded::slotFilterFinished restores the mouse pointer shape?

Bye

  Thorsten
Comment 8 Holger Wagemann 2010-08-30 14:01:01 UTC
Hello,

on an up-to-date PCLinuxOS with new qt 4.7 stuff and digikam 1.4.0 the error, Thorsten Schnebeck describes with more details, hasn't gone.

With best regards,
  Holger
Comment 9 Berthier Lemieux 2010-09-04 09:10:18 UTC
Created attachment 51297 [details]
Proposed patch to avoid the "infinite" spinning mouse cursor

As Thorsten already pointed out, upon preparing the final image after a WB change, WhiteBalanceTool pushes the wait cursor on the stack but that cursor is never popped out.

When preparing the final image, EditorToolThreaded also push his own wait cursor, and takes care to pop it out.

Other imageplugins (adjustcurve, for example) do not change the cursor in prepareFinal(), leaving it up for EdiotrToolThreaded to do it. I am thus proposing here the same solution for the WB tool.
Comment 10 caulier.gilles 2010-09-06 11:27:08 UTC
SVN commit 1172035 by cgilles:

fix busy cursor behavors in WB tool
BUGS: 237786


 M  +1 -2      whitebalancetool.cpp  
 M  +1 -2      whitebalancetool.h  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1172035