Bug 237452 - Tagging interface functionality lost
Summary: Tagging interface functionality lost
Status: RESOLVED FIXED
Alias: None
Product: digikam
Classification: Applications
Component: Tags-Engine (show other bugs)
Version: 1.2.0
Platform: Ubuntu Linux
: NOR normal
Target Milestone: ---
Assignee: Digikam Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-05-13 02:19 UTC by Sean T. Evans
Modified: 2012-06-27 07:38 UTC (History)
4 users (show)

See Also:
Latest Commit:
Version Fixed In: 2.6.0


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Sean T. Evans 2010-05-13 02:19:53 UTC
Version:           1.2.0 (using KDE 4.4.2)
OS:                Linux
Installed from:    Ubuntu Packages

In previous versions of Digikam the process I used for tagging was as follows:
Select image(s) -> Click in "Enter new tag here..." text box -> type tag -> if tag existed in DB, auto-complete suggestions appeared as I typed. When the tag I wished to use was displayed (in the case of a tag not in the DB, when I finished typing the word) I hit enter and then typed the next tag for the image. This allowed me to add several tags to a given image quickly and easily.

Now, it seems that the only way to enter tags is as follows:
Select image(s) -> Click in "Search" box -> type tag -> if tag exists in DB, auto-complete functions as before and I can select the tag -> remove hand from keyboard and move to mouse to click on the check box for the tag -> click in search box and delete previous search -> type in next tag -> if tag does not exist in DB, I then have to click in the "Enter new tag" box, and type the same word a second time.->mouse->click->mouse to "search box"->repeat.

This is a much, much less organic process, and is a major loss of functionality, as it takes as much as three times as long to add tags to an image. I'm not sure why this behavior was changed.
Comment 1 caulier.gilles 2010-05-13 18:44:13 UTC
Johannes, This due to QT4 model View port ?

Gilles
Comment 2 Johannes Wienke 2010-05-13 19:18:28 UTC
May be, it's already on my TODO list, but I don't have much time right now.
Comment 3 Mateusz Loskot 2010-05-23 18:28:55 UTC
I posted similar questions to the list (http://mail.kde.org/pipermail/digikam-users/2010-May/010452.html) and I'm interested in this functionality too.
Comment 4 Marcel Wiesweg 2010-06-05 16:32:07 UTC
Ensuring that a newly created tag is already checked and clearing the line edit are the low-hanging fruit.

I have some questions regarding the desired behavior:
- did the autocompletion show the tag name or the full path? In case of several tags with the same name under different parents, how did you choose the right one?
- when creating a new tag, was it done top-level or as child of the tag currently selected in the tree view?
Comment 5 Marcel Wiesweg 2010-06-05 16:35:31 UTC
SVN commit 1134869 by mwiesweg:

For creating a tag from the line edit, use the tag modification helper of the tree view
to make the check-new-tag functionality work.
Optimize the workflow for creating several new tags in a row.

CCBUG: 237452

 M  +4 -6      imagedescedittab.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1134869
Comment 6 Sean T. Evans 2010-06-05 16:39:16 UTC
(In reply to comment #4)
> I have some questions regarding the desired behavior:
> - did the autocompletion show the tag name or the full path? In case of several
> tags with the same name under different parents, how did you choose the right
> one?

Honestly, I only used a flat list, rather than a hierarchy, so I'm unable to answer this.

> - when creating a new tag, was it done top-level or as child of the tag
> currently selected in the tree view?

It created it as a child.
Comment 7 Claudio Piombetti 2010-06-08 14:15:31 UTC
Deeply missing the same functionality.

>> - did the autocompletion show the tag name or the full path?

Only the tag name was shown, no path.

> In case of several
> tags with the same name under different parents, how did you choose the right
> one?

I have a badly-organised multi-level tag structure, but no duplicates, so - AFAICR - no choice was offered (or needed).
Comment 8 Marcel Wiesweg 2010-06-20 21:45:17 UTC
SVN commit 1140473 by mwiesweg:

A line edit combined with a custom KCompletionBox (drop down box for completion)
optimized for assigning tags and creating new tags with the keyboard.

The drop down box shows the various choices:
- existing tags matching the current input
- for tags with the same name, the different occurrences in the hierarchy
- creating a new tag
- a tag can be created as child of the tag currently selected in the treeview,
  or a toplevel tag

The user can choose his action, continue typing or assign with the Return key.

CCBUG: 237452

 A             addtagslineedit.cpp   [License: GPL (v2+)]
 A             addtagslineedit.h   [License: GPL (v2+)]


WebSVN link: http://websvn.kde.org/?view=rev&revision=1140473
Comment 9 Marcel Wiesweg 2010-06-20 21:45:24 UTC
SVN commit 1140474 by mwiesweg:

Use the new AddTagsLineEdit in the imagedescedittab

CCBUG: 237452

 M  +1 -0      CMakeLists.txt  
 M  +37 -9     libs/imageproperties/imagedescedittab.cpp  
 M  +2 -0      libs/imageproperties/imagedescedittab.h  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1140474
Comment 10 Marcel Wiesweg 2010-06-20 21:49:54 UTC
I would appreciate testing of this new line edit with feedback by someone interested in tagging-by-typing. We need to fine-tune the usability.

I have tried to integrate different use cases (flat tag list vs. hierarchy, new tag creation vs. assigning).
Is the distinction of tags in the hierarchy vs. top-level tags made clear?
Is the selection of the current default action suitable?
Are different autocompletion modes desirable?
Comment 11 Claudio Piombetti 2010-09-27 14:46:55 UTC
Hello Marcel, sorry for the late reply. Been travelling and shooting for the past few months and did not use/check DigiKam because of this issue (#237452). If you need a tester, I am very interested in the tagging-by-typing feature and I am willing to help.
Comment 12 Marcel Wiesweg 2011-02-10 22:20:07 UTC
Any more comments here with 2.0? Would like to close unless problems are reported.
Comment 13 caulier.gilles 2011-12-16 12:35:29 UTC
Sean,

There are few work on this file. It still valid using digiKam 2.x serie ?

Gilles Caulier
Comment 14 Peter Albrecht 2012-01-18 21:23:39 UTC
I would say, this bug is fixed in digikam 2.5.0. I guess it has been fixed way earlier, but I don't know exactly at which version.

See also: bug #114465

My way of mouse-less tagging:
  1 select an album
  2 switch to "view image"-view (the bigger the picture, the better you can recognize the people, 
    you want to tag)
  3 switch the right sideview to "Caption/Tags" and select tab "Tags"
  4 click in the uppermost input box, which shows the text: "Enter new tag here..."
  5 look for the leftmost person, you have not tagged yet
  6 start typing a few letters of the desired tagname (You have to start with the first letters in your
    tag name. There is no "mid word matching".)
    -> you will see a list of possible tags appear that shrinks with every letter you add to the input box
  7 if the list is reduced enough, use TAB to select the desired tag from this list
  8 hit ENTER to assign this tag to your picture
  9 if there are more persons, you want to tag, go to step 5 again
 10 if all persons on this image have been tagged, hit PAGE_DOWN to go to the next image and 
    resume with step 5

This works great! Thanks a lot, dear developers!
I have 206 different tags in multilevel-hierarchical order. No Problem with those:
As long as the tagname is unique, the autocompletion-suggestion-list does only show the last nodes in the tag tree. Having two identical tags at different branches in the tree, the branch is also shown with them.


"High-level-wish": The list of autocomplete suggestions (accessible via TAB-key) seems to be sorted alphabetically. 
It would be a bit more useful to sort "last used first" or "most often used first". But I don't know if this can be easily added to the QT-Control.
The top listed elements will need less TAB-key presses to reach. => Faster tagging.

Aabout "last used first": When tagging my aunt's birthday party. Chances are very high, that I need the tag "Aunt Hilda" again, after assigning it to picture one. But I don't know, if digikam stores a "last used date" in the database. So this would mean quite some work.

About "most often used first": Chances are very high that I need certain tags, which I used a lot, with new pictures, too. E.g. my daughter's tag (used 3000 times) should be listed above aunt Hilda's tag (used 50 times), both starting with "H...".

But these are "high level wishes". I'm totaly happy with the current implementation. It's just a suggestion to make tagging a little tiny bit better. ;)