Bug 237022 - default names of new folders have a space in them
Summary: default names of new folders have a space in them
Status: RESOLVED FIXED
Alias: None
Product: dolphin
Classification: Applications
Component: general (show other bugs)
Version: 16.12.2
Platform: Compiled Sources Unspecified
: NOR wishlist
Target Milestone: ---
Assignee: Peter Penz
URL:
Keywords: junior-jobs
Depends on:
Blocks:
 
Reported: 2010-05-09 22:18 UTC by mtz.inc ..
Modified: 2010-09-01 08:23 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In: 4.6.0
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description mtz.inc .. 2010-05-09 22:18:42 UTC
Version:            (using Devel)
Installed from:    Compiled sources


right click on dolphin -> create new -> new folder and dolphin will create a folder with a name "New Folder", notice the space btw "New" and "Folder".

when the same action is taken again, dolphin will give the new folder this name "New Folder_1", notice again the space btw "New" and "Folder" and the substitution of space btw "Folder" and "1" with "_".

Linux programs that work from the terminal have issues dealing with empty spaces and it will be nice if all default names given by dolphin have "_" instead of spaces.

The removable of spaces will also give consistency in names, either have all spaces or all "_" in names.
Comment 1 Mark 2010-08-24 17:23:58 UTC
I think this is somewhat user specific.. I for instance want my folder names to just look good (with spaces) and just bear with the pain in the console. However, i will try to make a patch for this that adds a checkbox in the Bahavior tab (Configure dolphin -> General -> Behavior) along the lines:

[ ] New files and folders with underscores instead of spaces

default unchecked. When checked spaces will be replaced by underscores.

I do think the behavior should change anyway since right now you have both a underscore and a space : "New Folder_1"

When the above option is unchecked it should be:
"New Folder 1"

When checked it should be:
"New_Folder_1"
Comment 2 Peter Penz 2010-08-24 17:45:05 UTC
@Mark: Please don't make an option for such minor things, let's decide for one consistent naming approach instead ;-) From a Dolphin point of view I'd prefer having just spaces, as the target user group of Dolphin does not deal a lot with the terminal. However the code that suggests this name is outside the Dolphin code, so the final decision for this is not on my side, but on the corresponding maintainer. I'd suggest posting a patch to reviewboard.kde.org, so that it can be decided by the maintainer of the code what should go in (I think it is David Faure, but I did not check this yet). Before posting it to the reviewboard, feel free to send it to me per e-mail before if you want. Thanks!
Comment 3 Peter Penz 2010-09-01 08:23:07 UTC
SVN commit 1170488 by ppenz:

Use "New Folder 1" instead of "New Folder_1" when suggesting a name for an already existing directory (see reviewboard.kde.org/r/5160). Thanks to Mark for the patch!

BUG: 237022
FIXED-IN: 4.6.0



 M  +6 -5      renamedialog.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1170488